Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: webrtc/video/vie_receiver.cc

Issue 1674663002: Initialize VideoSendStream members in constructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback + test update Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_channel.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_receiver.cc
diff --git a/webrtc/video/vie_receiver.cc b/webrtc/video/vie_receiver.cc
index 24c9aad3f13c561441356409657023e837c6e855..8fcb380f92b03f552bf839c17307e8cdd9b7ea7d 100644
--- a/webrtc/video/vie_receiver.cc
+++ b/webrtc/video/vie_receiver.cc
@@ -55,9 +55,7 @@ ViEReceiver::ViEReceiver(VideoCodingModule* module_vcm,
receiving_ast_enabled_(false),
receiving_cvo_enabled_(false),
receiving_tsn_enabled_(false),
- last_packet_log_ms_(-1) {
- assert(remote_bitrate_estimator);
-}
+ last_packet_log_ms_(-1) {}
ViEReceiver::~ViEReceiver() {
UpdateHistograms();
@@ -246,6 +244,7 @@ bool ViEReceiver::OnRecoveredPacket(const uint8_t* rtp_packet,
bool ViEReceiver::DeliverRtp(const uint8_t* rtp_packet,
size_t rtp_packet_length,
const PacketTime& packet_time) {
+ RTC_DCHECK(remote_bitrate_estimator_);
stefan-webrtc 2016/02/11 12:28:06 Why not keep it up there to fail as early as possi
pbos-webrtc 2016/02/11 12:48:13 nullptr on the sender side, which shouldn't call D
{
rtc::CritScope lock(&receive_cs_);
if (!receiving_) {
« no previous file with comments | « webrtc/video/vie_channel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698