Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1625363002: AudioCodingModuleImpl: Put CodecManager and Rent-A-Codec in a separate struct (Closed)

Created:
4 years, 11 months ago by kwiberg-webrtc
Modified:
4 years, 11 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac2
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AudioCodingModuleImpl: Put CodecManager and Rent-A-Codec in a separate struct This will make it easier for future CLs to make them optional. BUG=webrtc:5028 Committed: https://crrev.com/83277131b1d22a5cd4243994cbc36501e8096845 Cr-Commit-Position: refs/heads/master@{#11381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 1 chunk +9 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 7 chunks +26 lines, -24 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 11 months ago (2016-01-25 02:49:57 UTC) #3
hlundin-webrtc
lgtm
4 years, 11 months ago (2016-01-26 07:21:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625363002/1
4 years, 11 months ago (2016-01-26 12:49:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 14:06:18 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 14:06:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83277131b1d22a5cd4243994cbc36501e8096845
Cr-Commit-Position: refs/heads/master@{#11381}

Powered by Google App Engine
This is Rietveld 408576698