Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

Issue 1625363002: AudioCodingModuleImpl: Put CodecManager and Rent-A-Codec in a separate struct (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@rac2
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 int UpdateUponReceivingCodec(int index); 241 int UpdateUponReceivingCodec(int index);
242 242
243 mutable rtc::CriticalSection acm_crit_sect_; 243 mutable rtc::CriticalSection acm_crit_sect_;
244 rtc::Buffer encode_buffer_ GUARDED_BY(acm_crit_sect_); 244 rtc::Buffer encode_buffer_ GUARDED_BY(acm_crit_sect_);
245 int id_; // TODO(henrik.lundin) Make const. 245 int id_; // TODO(henrik.lundin) Make const.
246 uint32_t expected_codec_ts_ GUARDED_BY(acm_crit_sect_); 246 uint32_t expected_codec_ts_ GUARDED_BY(acm_crit_sect_);
247 uint32_t expected_in_ts_ GUARDED_BY(acm_crit_sect_); 247 uint32_t expected_in_ts_ GUARDED_BY(acm_crit_sect_);
248 ACMResampler resampler_ GUARDED_BY(acm_crit_sect_); 248 ACMResampler resampler_ GUARDED_BY(acm_crit_sect_);
249 AcmReceiver receiver_; // AcmReceiver has it's own internal lock. 249 AcmReceiver receiver_; // AcmReceiver has it's own internal lock.
250 ChangeLogger bitrate_logger_ GUARDED_BY(acm_crit_sect_); 250 ChangeLogger bitrate_logger_ GUARDED_BY(acm_crit_sect_);
251 CodecManager codec_manager_ GUARDED_BY(acm_crit_sect_);
252 RentACodec rent_a_codec_ GUARDED_BY(acm_crit_sect_);
253 251
254 // Last encoder stack obtained from rent_a_codec_.RentEncoderStack. 252 struct EncoderFactory {
253 CodecManager codec_manager;
254 RentACodec rent_a_codec;
255 };
256 rtc::scoped_ptr<EncoderFactory> encoder_factory_ GUARDED_BY(acm_crit_sect_);
257
258 // Current encoder stack, either obtained from
259 // encoder_factory_->rent_a_codec.RentEncoderStack or provided by a call to
260 // RegisterEncoder.
255 AudioEncoder* encoder_stack_ GUARDED_BY(acm_crit_sect_); 261 AudioEncoder* encoder_stack_ GUARDED_BY(acm_crit_sect_);
256 262
257 // This is to keep track of CN instances where we can send DTMFs. 263 // This is to keep track of CN instances where we can send DTMFs.
258 uint8_t previous_pltype_ GUARDED_BY(acm_crit_sect_); 264 uint8_t previous_pltype_ GUARDED_BY(acm_crit_sect_);
259 265
260 // Used when payloads are pushed into ACM without any RTP info 266 // Used when payloads are pushed into ACM without any RTP info
261 // One example is when pre-encoded bit-stream is pushed from 267 // One example is when pre-encoded bit-stream is pushed from
262 // a file. 268 // a file.
263 // IMPORTANT: this variable is only used in IncomingPayload(), therefore, 269 // IMPORTANT: this variable is only used in IncomingPayload(), therefore,
264 // no lock acquired when interacting with this variable. If it is going to 270 // no lock acquired when interacting with this variable. If it is going to
(...skipping 12 matching lines...) Expand all
277 mutable rtc::CriticalSection callback_crit_sect_; 283 mutable rtc::CriticalSection callback_crit_sect_;
278 AudioPacketizationCallback* packetization_callback_ 284 AudioPacketizationCallback* packetization_callback_
279 GUARDED_BY(callback_crit_sect_); 285 GUARDED_BY(callback_crit_sect_);
280 ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_); 286 ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_);
281 }; 287 };
282 288
283 } // namespace acm2 289 } // namespace acm2
284 } // namespace webrtc 290 } // namespace webrtc
285 291
286 #endif // WEBRTC_MODULES_AUDIO_CODING_ACM2_AUDIO_CODING_MODULE_IMPL_H_ 292 #endif // WEBRTC_MODULES_AUDIO_CODING_ACM2_AUDIO_CODING_MODULE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698