Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1631443002: AudioCodingModuleImpl: Initialize encoder_stack_ to nullptr (Closed)

Created:
4 years, 11 months ago by kwiberg-webrtc
Modified:
4 years, 11 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AudioCodingModuleImpl: Initialize encoder_stack_ to nullptr This should have been done in commit 11340, but it was left out by mistake. BUG=webrtc:5028 Committed: https://crrev.com/6a07f12e95055dc8501161532118c7ef6db08a75 Cr-Commit-Position: refs/heads/master@{#11378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 11 months ago (2016-01-25 02:47:45 UTC) #3
hlundin-webrtc
lgtm
4 years, 11 months ago (2016-01-26 07:19:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631443002/1
4 years, 11 months ago (2016-01-26 09:30:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 11:28:54 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 11:29:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a07f12e95055dc8501161532118c7ef6db08a75
Cr-Commit-Position: refs/heads/master@{#11378}

Powered by Google App Engine
This is Rietveld 408576698