Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1613643004: Remove mutable from rtc::CriticalSection members. (Closed)

Created:
4 years, 11 months ago by pbos-webrtc
Modified:
4 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, peah-webrtc, andresp, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, the sun, pbos-webrtc, perkj_webrtc, aluebs-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove mutable from rtc::CriticalSection members. rtc::CriticalSection is now lockable from const methods and no longer need to remain mutable. BUG= R=tommi@webrtc.org Committed: https://crrev.com/5ad935cb56e8647d42dffdbb8897f31294e1c272 Cr-Commit-Position: refs/heads/master@{#11367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M talk/app/webrtc/test/fakeaudiocapturemodule.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/capturerenderadapter.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/fakevideorenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/devices/filevideocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/devices/yuvframescapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_state.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/bufferqueue.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/messagequeue.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/physicalsocketserver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/thread_checker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/bitrate_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/congestion_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_video/include/incoming_video_stream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/Channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_performance_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/video_processing_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/source/clock.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_audio_device.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_network_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
pbos-webrtc
PTAL, to be landed after https://codereview.webrtc.org/1611223002/.
4 years, 11 months ago (2016-01-21 15:45:42 UTC) #1
tommi
lgtm assuming you'll run through the cq
4 years, 11 months ago (2016-01-21 15:46:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613643004/1
4 years, 11 months ago (2016-01-21 15:57:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 11 months ago (2016-01-21 17:57:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613643004/1
4 years, 11 months ago (2016-01-25 10:51:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 11:52:49 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 11:53:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ad935cb56e8647d42dffdbb8897f31294e1c272
Cr-Commit-Position: refs/heads/master@{#11367}

Powered by Google App Engine
This is Rietveld 408576698