Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: webrtc/base/thread_unittest.cc

Issue 1613643004: Remove mutable from rtc::CriticalSection members. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/thread_checker_impl.h ('k') | webrtc/call/bitrate_allocator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 CritScope scoped_lock(&cs_); 157 CritScope scoped_lock(&cs_);
158 flag_ = value; 158 flag_ = value;
159 return *this; 159 return *this;
160 } 160 }
161 bool get() const { 161 bool get() const {
162 CritScope scoped_lock(&cs_); 162 CritScope scoped_lock(&cs_);
163 return flag_; 163 return flag_;
164 } 164 }
165 165
166 private: 166 private:
167 mutable CriticalSection cs_; 167 CriticalSection cs_;
168 bool flag_; 168 bool flag_;
169 }; 169 };
170 170
171 // Function objects to test Thread::Invoke. 171 // Function objects to test Thread::Invoke.
172 struct FunctorA { 172 struct FunctorA {
173 int operator()() { return 42; } 173 int operator()() { return 42; }
174 }; 174 };
175 class FunctorB { 175 class FunctorB {
176 public: 176 public:
177 explicit FunctorB(AtomicBool* flag) : flag_(flag) {} 177 explicit FunctorB(AtomicBool* flag) : flag_(flag) {}
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 }; 717 };
718 718
719 TEST_F(ComThreadTest, ComInited) { 719 TEST_F(ComThreadTest, ComInited) {
720 Thread* thread = new ComThread(); 720 Thread* thread = new ComThread();
721 EXPECT_TRUE(thread->Start()); 721 EXPECT_TRUE(thread->Start());
722 thread->Post(this, 0); 722 thread->Post(this, 0);
723 EXPECT_TRUE_WAIT(done_, 1000); 723 EXPECT_TRUE_WAIT(done_, 1000);
724 delete thread; 724 delete thread;
725 } 725 }
726 #endif 726 #endif
OLDNEW
« no previous file with comments | « webrtc/base/thread_checker_impl.h ('k') | webrtc/call/bitrate_allocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698