webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h - Issue 1613643004: Remove mutable from rtc::CriticalSection members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

Issue 1613643004: Remove mutable from rtc::CriticalSection members. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/acm2/acm_receiver.h ('k') | webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

index 2a3bc6140591eceeafb5ed27edce662bc18ae34c..6750a91ea100efda991f6ccd37790d4ad00bc5e4 100644

--- a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

+++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

@@ -240,7 +240,7 @@ class AudioCodingModuleImpl final : public AudioCodingModule {

// to |index|.

int UpdateUponReceivingCodec(int index);

- mutable rtc::CriticalSection acm_crit_sect_;

+ rtc::CriticalSection acm_crit_sect_;

rtc::Buffer encode_buffer_ GUARDED_BY(acm_crit_sect_);

int id_; // TODO(henrik.lundin) Make const.

uint32_t expected_codec_ts_ GUARDED_BY(acm_crit_sect_);

@@ -274,7 +274,7 @@ class AudioCodingModuleImpl final : public AudioCodingModule {

uint32_t last_timestamp_ GUARDED_BY(acm_crit_sect_);

uint32_t last_rtp_timestamp_ GUARDED_BY(acm_crit_sect_);

- mutable rtc::CriticalSection callback_crit_sect_;

+ rtc::CriticalSection callback_crit_sect_;

AudioPacketizationCallback* packetization_callback_

GUARDED_BY(callback_crit_sect_);

ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_);