Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video.

Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video.
While doing this, I made a couple of minor changes:
* Removed unused variables (one lock and one video frame variable)
* Switched over to a scoped lock in remb.cc and removed an if() in a function where we can just return the expression being checked.

BUG=
R=mflodman@webrtc.org

Committed: https://crrev.com/97888bd95a32c0fe3709a096cf37e116320f29e4
Cr-Commit-Position: refs/heads/master@{#11349}

[tommi, 2016-01-21 11:46:20]

tommi@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[tommi, 2016-01-21 11:46:21]

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/payload_router.h
File webrtc/video/payload_router.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/payload_router.h...
webrtc/video/payload_router.h:70: // TODO(mflodman): When the new video API has
launched, remove crit_ and
maybe we can do this now? (not this cl of course, but now that the video API has
launched?)

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_remb.cc
File webrtc/video/vie_remb.cc (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_remb.cc#newc...
webrtc/video/vie_remb.cc:90: return !receive_modules_.empty() ||
!rtcp_sender_.empty();
please review this change specially

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_remb.cc#newc...
webrtc/video/vie_remb.cc:97: rtc::CritScope lock(&list_crit_);
and this one too

[tommi, 2016-01-21 13:03:11]

the red bots are complaining about a missing file in trunk.  I've synced to head
and things are fine there, so maybe there's a bot specific problem.  I think we
can ignore it for now.

[mflodman, 2016-01-21 13:25:24]

One real comment, then lgtm.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/payload_router.h
File webrtc/video/payload_router.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/payload_router.h...
webrtc/video/payload_router.h:70: // TODO(mflodman): When the new video API has
launched, remove crit_ and
On 2016/01/21 11:46:20, tommi-webrtc wrote:
> maybe we can do this now? (not this cl of course, but now that the video API
has
> launched?)

We're working on moving around stuff, so it's in the pipe of things to do.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/video_capture_in...
File webrtc/video/video_capture_input.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/video_capture_in...
webrtc/video/video_capture_input.h:66: mutable rtc::CriticalSection capture_cs_;
Feel free to rename to crit_, or similar, if you want to. Since there is only
one critical section remaining in this class. Otherwise we'll do it later.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_receiver.h
File webrtc/video/vie_receiver.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_receiver.h#n...
webrtc/video/vie_receiver.h:107: rtc::CriticalSection receive_cs_;
mutable.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_remb.cc
File webrtc/video/vie_remb.cc (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_remb.cc#newc...
webrtc/video/vie_remb.cc:90: return !receive_modules_.empty() ||
!rtcp_sender_.empty();
On 2016/01/21 11:46:20, tommi-webrtc wrote:
> please review this change specially

Acknowledged.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_remb.cc#newc...
webrtc/video/vie_remb.cc:97: rtc::CritScope lock(&list_crit_);
On 2016/01/21 11:46:20, tommi-webrtc wrote:
> and this one too

Acknowledged.

[tommi, 2016-01-21 16:00:45]

Address comments

[tommi, 2016-01-21 16:00:50]

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/payload_router.h
File webrtc/video/payload_router.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/payload_router.h...
webrtc/video/payload_router.h:70: // TODO(mflodman): When the new video API has
launched, remove crit_ and
On 2016/01/21 13:25:23, mflodman wrote:
> On 2016/01/21 11:46:20, tommi-webrtc wrote:
> > maybe we can do this now? (not this cl of course, but now that the video API
> has
> > launched?)
> 
> We're working on moving around stuff, so it's in the pipe of things to do.

Acknowledged.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/video_capture_in...
File webrtc/video/video_capture_input.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/video_capture_in...
webrtc/video/video_capture_input.h:66: mutable rtc::CriticalSection capture_cs_;
On 2016/01/21 13:25:23, mflodman wrote:
> Feel free to rename to crit_, or similar, if you want to. Since there is only
> one critical section remaining in this class. Otherwise we'll do it later.

Done.

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_receiver.h
File webrtc/video/vie_receiver.h (right):

https://codereview.webrtc.org/1613053003/diff/1/webrtc/video/vie_receiver.h#n...
webrtc/video/vie_receiver.h:107: rtc::CriticalSection receive_cs_;
On 2016/01/21 13:25:23, mflodman wrote:
> mutable.

pbos is changing the criticalsection class to not require mutable at all and
update places where I've added mutable, to not have it.

[tommi, 2016-01-21 16:01:55]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-01-21 16:01:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1613053003/#ps20001 (title:
"Address comments")

[commit-bot: I haz the power, 2016-01-21 16:02:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1613053003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1613053003/20001

[commit-bot: I haz the power, 2016-01-21 18:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 18:02:50]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tommi, 2016-01-21 18:36:15]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2016-01-21 18:36:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1613053003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1613053003/20001

[commit-bot: I haz the power, 2016-01-21 20:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 20:36:38]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/8541)

[tommi, 2016-01-21 22:24:05]

Rebase?

[tommi, 2016-01-21 22:24:39]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-01-21 22:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1613053003/#ps40001 (title:
"Rebase?")

[commit-bot: I haz the power, 2016-01-21 22:24:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1613053003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1613053003/40001

[tommi, 2016-01-21 22:25:17]

Description was changed from

==========
Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video.
While doing this, I made a couple of minor changes:
* Removed unused variables (one lock and one video frame variable)
* Switched over to a scoped lock in remb.cc and removed an if() in a function
where we can just return the expression being checked.

BUG=
==========

to

==========
Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video.
While doing this, I made a couple of minor changes:
* Removed unused variables (one lock and one video frame variable)
* Switched over to a scoped lock in remb.cc and removed an if() in a function
where we can just return the expression being checked.

BUG=
R=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/97888bd95a32c0fe3709a096c...
==========

[commit-bot: I haz the power, 2016-01-21 22:25:18]

Description was changed from

==========
Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video.
While doing this, I made a couple of minor changes:
* Removed unused variables (one lock and one video frame variable)
* Switched over to a scoped lock in remb.cc and removed an if() in a function
where we can just return the expression being checked.

BUG=
R=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/97888bd95a32c0fe3709a096c...
==========

to

==========
Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video.
While doing this, I made a couple of minor changes:
* Removed unused variables (one lock and one video frame variable)
* Switched over to a scoped lock in remb.cc and removed an if() in a function
where we can just return the expression being checked.

BUG=
R=mflodman@webrtc.org

Committed: https://crrev.com/97888bd95a32c0fe3709a096cf37e116320f29e4
Cr-Commit-Position: refs/heads/master@{#11349}
==========

[tommi, 2016-01-21 22:25:19]

Committed patchset #3 (id:40001) manually as
97888bd95a32c0fe3709a096cf37e116320f29e4 (presubmit successful).

[commit-bot: I haz the power, 2016-01-21 22:25:19]

Patchset 3 (id:??) landed as
https://crrev.com/97888bd95a32c0fe3709a096cf37e116320f29e4
Cr-Commit-Position: refs/heads/master@{#11349}