Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: webrtc/video/payload_router.h

Issue 1613053003: Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase? Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/end_to_end_tests.cc ('k') | webrtc/video/payload_router.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_VIDEO_PAYLOAD_ROUTER_H_ 11 #ifndef WEBRTC_VIDEO_PAYLOAD_ROUTER_H_
12 #define WEBRTC_VIDEO_PAYLOAD_ROUTER_H_ 12 #define WEBRTC_VIDEO_PAYLOAD_ROUTER_H_
13 13
14 #include <list> 14 #include <list>
15 #include <vector> 15 #include <vector>
16 16
17 #include "webrtc/base/constructormagic.h" 17 #include "webrtc/base/constructormagic.h"
18 #include "webrtc/base/criticalsection.h"
18 #include "webrtc/base/scoped_ptr.h" 19 #include "webrtc/base/scoped_ptr.h"
19 #include "webrtc/base/thread_annotations.h" 20 #include "webrtc/base/thread_annotations.h"
20 #include "webrtc/common_types.h" 21 #include "webrtc/common_types.h"
21 #include "webrtc/system_wrappers/include/atomic32.h" 22 #include "webrtc/system_wrappers/include/atomic32.h"
22 23
23 namespace webrtc { 24 namespace webrtc {
24 25
25 class CriticalSectionWrapper;
26 class RTPFragmentationHeader; 26 class RTPFragmentationHeader;
27 class RtpRtcp; 27 class RtpRtcp;
28 struct RTPVideoHeader; 28 struct RTPVideoHeader;
29 29
30 // PayloadRouter routes outgoing data to the correct sending RTP module, based 30 // PayloadRouter routes outgoing data to the correct sending RTP module, based
31 // on the simulcast layer in RTPVideoHeader. 31 // on the simulcast layer in RTPVideoHeader.
32 class PayloadRouter { 32 class PayloadRouter {
33 public: 33 public:
34 PayloadRouter(); 34 PayloadRouter();
35 ~PayloadRouter(); 35 ~PayloadRouter();
(...skipping 26 matching lines...) Expand all
62 // Returns the maximum allowed data payload length, given the configured MTU 62 // Returns the maximum allowed data payload length, given the configured MTU
63 // and RTP headers. 63 // and RTP headers.
64 size_t MaxPayloadLength() const; 64 size_t MaxPayloadLength() const;
65 65
66 void AddRef() { ++ref_count_; } 66 void AddRef() { ++ref_count_; }
67 void Release() { if (--ref_count_ == 0) { delete this; } } 67 void Release() { if (--ref_count_ == 0) { delete this; } }
68 68
69 private: 69 private:
70 // TODO(mflodman): When the new video API has launched, remove crit_ and 70 // TODO(mflodman): When the new video API has launched, remove crit_ and
71 // assume rtp_modules_ will never change during a call. 71 // assume rtp_modules_ will never change during a call.
72 rtc::scoped_ptr<CriticalSectionWrapper> crit_; 72 mutable rtc::CriticalSection crit_;
73 73
74 // Active sending RTP modules, in layer order. 74 // Active sending RTP modules, in layer order.
75 std::vector<RtpRtcp*> rtp_modules_ GUARDED_BY(crit_.get()); 75 std::vector<RtpRtcp*> rtp_modules_ GUARDED_BY(crit_);
76 bool active_ GUARDED_BY(crit_.get()); 76 bool active_ GUARDED_BY(crit_);
77 77
78 Atomic32 ref_count_; 78 Atomic32 ref_count_;
79 79
80 RTC_DISALLOW_COPY_AND_ASSIGN(PayloadRouter); 80 RTC_DISALLOW_COPY_AND_ASSIGN(PayloadRouter);
81 }; 81 };
82 82
83 } // namespace webrtc 83 } // namespace webrtc
84 84
85 #endif // WEBRTC_VIDEO_PAYLOAD_ROUTER_H_ 85 #endif // WEBRTC_VIDEO_PAYLOAD_ROUTER_H_
OLDNEW
« no previous file with comments | « webrtc/video/end_to_end_tests.cc ('k') | webrtc/video/payload_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698