Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: webrtc/video/vie_receiver.cc

Issue 1613053003: Swap use of CriticalSectionWrapper for rtc::CriticalSection in webrtc/video. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase? Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/vie_receiver.h ('k') | webrtc/video/vie_remb.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_receiver.cc
diff --git a/webrtc/video/vie_receiver.cc b/webrtc/video/vie_receiver.cc
index 4fb706c76450fba3ec65c1a3b2662b575353d4e8..da14a3ceff3aeb94558c05b35c49ef544f88ce58 100644
--- a/webrtc/video/vie_receiver.cc
+++ b/webrtc/video/vie_receiver.cc
@@ -23,7 +23,6 @@
#include "webrtc/modules/rtp_rtcp/include/rtp_receiver.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
#include "webrtc/modules/video_coding/include/video_coding.h"
-#include "webrtc/system_wrappers/include/critical_section_wrapper.h"
#include "webrtc/system_wrappers/include/metrics.h"
#include "webrtc/system_wrappers/include/tick_util.h"
#include "webrtc/system_wrappers/include/timestamp_extrapolator.h"
@@ -36,8 +35,7 @@ static const int kPacketLogIntervalMs = 10000;
ViEReceiver::ViEReceiver(VideoCodingModule* module_vcm,
RemoteBitrateEstimator* remote_bitrate_estimator,
RtpFeedback* rtp_feedback)
- : receive_cs_(CriticalSectionWrapper::CreateCriticalSection()),
- clock_(Clock::GetRealTimeClock()),
+ : clock_(Clock::GetRealTimeClock()),
rtp_header_parser_(RtpHeaderParser::Create()),
rtp_payload_registry_(
new RTPPayloadRegistry(RTPPayloadStrategy::CreateStrategy(false))),
@@ -153,7 +151,7 @@ RtpReceiver* ViEReceiver::GetRtpReceiver() const {
void ViEReceiver::RegisterRtpRtcpModules(
const std::vector<RtpRtcp*>& rtp_modules) {
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
// Only change the "simulcast" modules, the base module can be accessed
// without a lock whereas the simulcast modules require locking as they can be
// changed in runtime.
@@ -262,7 +260,7 @@ int ViEReceiver::InsertRTPPacket(const uint8_t* rtp_packet,
size_t rtp_packet_length,
const PacketTime& packet_time) {
{
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
if (!receiving_) {
return -1;
}
@@ -283,7 +281,7 @@ int ViEReceiver::InsertRTPPacket(const uint8_t* rtp_packet,
{
// Periodically log the RTP header of incoming packets.
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
if (now_ms - last_packet_log_ms_ > kPacketLogIntervalMs) {
std::stringstream ss;
ss << "Packet received on SSRC: " << header.ssrc << " with payload type: "
@@ -361,7 +359,7 @@ bool ViEReceiver::ParseAndHandleEncapsulatingHeader(const uint8_t* packet,
return false;
if (packet_length > sizeof(restored_packet_))
return false;
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
if (restored_packet_in_use_) {
LOG(LS_WARNING) << "Multiple RTX headers detected, dropping packet.";
return false;
@@ -410,7 +408,7 @@ void ViEReceiver::NotifyReceiverOfFecPacket(const RTPHeader& header) {
int ViEReceiver::InsertRTCPPacket(const uint8_t* rtcp_packet,
size_t rtcp_packet_length) {
{
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
if (!receiving_) {
return -1;
}
@@ -444,12 +442,12 @@ int ViEReceiver::InsertRTCPPacket(const uint8_t* rtcp_packet,
}
void ViEReceiver::StartReceive() {
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
receiving_ = true;
}
void ViEReceiver::StopReceive() {
- CriticalSectionScoped cs(receive_cs_.get());
+ rtc::CritScope lock(&receive_cs_);
receiving_ = false;
}
« no previous file with comments | « webrtc/video/vie_receiver.h ('k') | webrtc/video/vie_remb.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698