Remove extra_options from VideoCodec.

Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/7b971e728b614fa46aca88793ccb69ba80069fb9

[pbos-webrtc, 2016-01-19 11:18:09]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 11:18:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606613003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606613003/1

[pbos-webrtc, 2016-01-19 11:22:33]

Description was changed from

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

BUG=webrtc:5410
R=mflodman@webrtc.org
==========

to

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=mflodman@webrtc.org
==========

[pbos-webrtc, 2016-01-19 11:24:18]

PTAL, need to remove the webrtc::Config use for race-free temporal layer setup
across multiple encoders. This fixes TSan issues locally for follow-up CL
(https://codereview.webrtc.org/1600973002/)

[commit-bot: I haz the power, 2016-01-19 12:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 12:11:38]

Dry run: Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/10423)

[pbos-webrtc, 2016-01-19 14:32:43]

add delete operators

[pbos-webrtc, 2016-01-19 14:39:00]

.

[pbos-webrtc, 2016-01-19 14:39:24]

Description was changed from

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=mflodman@webrtc.org
==========

to

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=mflodman@webrtc.org, stefan@webrtc.org
==========

[pbos-webrtc, 2016-01-19 14:39:24]

pbos@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-01-19 14:58:25]

lgtm, but we should probably fix my minor comment.

https://codereview.webrtc.org/1606613003/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/1606613003/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:60: struct
RealTimeTemporalLayersFactory : TemporalLayersFactory {
class RealTimeTemporalLayersFactory : public TemporalLayersFactory {
??

[pbos-webrtc, 2016-01-19 15:22:14]

class

[pbos-webrtc, 2016-01-19 15:22:21]

https://codereview.webrtc.org/1606613003/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/1606613003/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:60: struct
RealTimeTemporalLayersFactory : TemporalLayersFactory {
On 2016/01/19 14:58:25, stefan-webrtc (holmer) wrote:
> class RealTimeTemporalLayersFactory : public TemporalLayersFactory {
> ??

Done.

[pbos-webrtc, 2016-01-19 15:22:48]

Description was changed from

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=mflodman@webrtc.org, stefan@webrtc.org
==========

to

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

[pbos-webrtc, 2016-01-19 15:23:01]

TBR=mflodman@ for webrtc/common_types.h.

[pbos-webrtc, 2016-01-19 15:25:57]

compile

[commit-bot: I haz the power, 2016-01-19 15:26:27]

Description was changed from

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=stefan@webrtc.org
TBR=mflodman@webrtc.org
==========

to

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/7b971e728b614fa46aca88793ccb69ba80069fb9
Cr-Commit-Position: refs/heads/master@{#11307}
==========

[commit-bot: I haz the power, 2016-01-19 15:26:28]

Patchset 5 (id:??) landed as
https://crrev.com/7b971e728b614fa46aca88793ccb69ba80069fb9
Cr-Commit-Position: refs/heads/master@{#11307}

[pbos-webrtc, 2016-01-19 15:26:28]

Description was changed from

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed: https://crrev.com/7b971e728b614fa46aca88793ccb69ba80069fb9
Cr-Commit-Position: refs/heads/master@{#11307}
==========

to

==========
Remove extra_options from VideoCodec.

Constructing default options is racy when initializing multiple VP8
encoders in parallel. This is only used for VP8 temporal layers. Adding
TemporalLayerFactory to VP8 codec specifics instead of generic options.

Removes the last webrtc::Config uses/includes from video code.

Also removes VideoCodec equality operators which are no longer in use.

BUG=webrtc:5410
R=stefan@webrtc.org
TBR=mflodman@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/7b971e728b614fa46aca88793...
==========

[pbos-webrtc, 2016-01-19 15:26:29]

Committed patchset #5 (id:80001) manually as
7b971e728b614fa46aca88793ccb69ba80069fb9 (presubmit successful).