webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc - Issue 1606613003: Remove extra_options from VideoCodec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

Issue 1606613003: Remove extra_options from VideoCodec. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: compile Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc ('k') | webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

index 86b8e0b345036ce8ec60d3752532fd5d0e7e269c..1340af3e6ab03c2b9a11d207532e5505211ed9b9 100644

--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

@@ -278,10 +278,11 @@ class TestSimulcastEncoderAdapterFake : public ::testing::Test,

target.codecSpecific.VP8.frameDroppingOn);

EXPECT_EQ(ref.codecSpecific.VP8.keyFrameInterval,

target.codecSpecific.VP8.keyFrameInterval);

+ EXPECT_EQ(ref.codecSpecific.VP8.tl_factory,

+ target.codecSpecific.VP8.tl_factory);

EXPECT_EQ(ref.qpMax, target.qpMax);

EXPECT_EQ(0, target.numberOfSimulcastStreams);

EXPECT_EQ(ref.mode, target.mode);

- EXPECT_EQ(ref.extra_options, target.extra_options);

// No need to compare simulcastStream as numberOfSimulcastStreams should

// always be 0.