Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc

Issue 1606613003: Remove extra_options from VideoCodec. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: compile Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 EXPECT_EQ(ref.codecSpecific.VP8.denoisingOn, 271 EXPECT_EQ(ref.codecSpecific.VP8.denoisingOn,
272 target.codecSpecific.VP8.denoisingOn); 272 target.codecSpecific.VP8.denoisingOn);
273 EXPECT_EQ(ref.codecSpecific.VP8.errorConcealmentOn, 273 EXPECT_EQ(ref.codecSpecific.VP8.errorConcealmentOn,
274 target.codecSpecific.VP8.errorConcealmentOn); 274 target.codecSpecific.VP8.errorConcealmentOn);
275 EXPECT_EQ(ref.codecSpecific.VP8.automaticResizeOn, 275 EXPECT_EQ(ref.codecSpecific.VP8.automaticResizeOn,
276 target.codecSpecific.VP8.automaticResizeOn); 276 target.codecSpecific.VP8.automaticResizeOn);
277 EXPECT_EQ(ref.codecSpecific.VP8.frameDroppingOn, 277 EXPECT_EQ(ref.codecSpecific.VP8.frameDroppingOn,
278 target.codecSpecific.VP8.frameDroppingOn); 278 target.codecSpecific.VP8.frameDroppingOn);
279 EXPECT_EQ(ref.codecSpecific.VP8.keyFrameInterval, 279 EXPECT_EQ(ref.codecSpecific.VP8.keyFrameInterval,
280 target.codecSpecific.VP8.keyFrameInterval); 280 target.codecSpecific.VP8.keyFrameInterval);
281 EXPECT_EQ(ref.codecSpecific.VP8.tl_factory,
282 target.codecSpecific.VP8.tl_factory);
281 EXPECT_EQ(ref.qpMax, target.qpMax); 283 EXPECT_EQ(ref.qpMax, target.qpMax);
282 EXPECT_EQ(0, target.numberOfSimulcastStreams); 284 EXPECT_EQ(0, target.numberOfSimulcastStreams);
283 EXPECT_EQ(ref.mode, target.mode); 285 EXPECT_EQ(ref.mode, target.mode);
284 EXPECT_EQ(ref.extra_options, target.extra_options);
285 286
286 // No need to compare simulcastStream as numberOfSimulcastStreams should 287 // No need to compare simulcastStream as numberOfSimulcastStreams should
287 // always be 0. 288 // always be 0.
288 } 289 }
289 290
290 void InitRefCodec(int stream_index, VideoCodec* ref_codec) { 291 void InitRefCodec(int stream_index, VideoCodec* ref_codec) {
291 *ref_codec = codec_; 292 *ref_codec = codec_;
292 ref_codec->codecSpecific.VP8.numberOfTemporalLayers = 293 ref_codec->codecSpecific.VP8.numberOfTemporalLayers =
293 kTestTemporalLayerProfile[stream_index]; 294 kTestTemporalLayerProfile[stream_index];
294 ref_codec->width = codec_.simulcastStream[stream_index].width; 295 ref_codec->width = codec_.simulcastStream[stream_index].width;
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 EXPECT_EQ(0, adapter_->InitEncode(&codec_, 1, 1200)); 407 EXPECT_EQ(0, adapter_->InitEncode(&codec_, 1, 1200));
407 adapter_->RegisterEncodeCompleteCallback(this); 408 adapter_->RegisterEncodeCompleteCallback(this);
408 ASSERT_EQ(3u, helper_->factory()->encoders().size()); 409 ASSERT_EQ(3u, helper_->factory()->encoders().size());
409 for (MockVideoEncoder* encoder : helper_->factory()->encoders()) 410 for (MockVideoEncoder* encoder : helper_->factory()->encoders())
410 encoder->set_supports_native_handle(true); 411 encoder->set_supports_native_handle(true);
411 EXPECT_FALSE(adapter_->SupportsNativeHandle()); 412 EXPECT_FALSE(adapter_->SupportsNativeHandle());
412 } 413 }
413 414
414 } // namespace testing 415 } // namespace testing
415 } // namespace webrtc 416 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698