Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1590333004: Making WebRtcSession fire a destroyed signal. (Closed)

Created:
4 years, 11 months ago by Taylor Brandstetter
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making WebRtcSession fire a destroyed signal. This ensures the DtmfSender won't try to access it after it's destroyed. BUG=webrtc:5403 Committed: https://crrev.com/057ecf01e4c2bc927481204192375dd5afd8d2f5 Cr-Commit-Position: refs/heads/master@{#11327}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M talk/app/webrtc/dtmfsender.cc View 2 chunks +2 lines, -4 lines 1 comment Download
M talk/app/webrtc/webrtcsession.h View 1 chunk +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 2 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 4 chunks +13 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
Taylor Brandstetter
PTAL. https://codereview.webrtc.org/1590333004/diff/1/talk/app/webrtc/dtmfsender.cc File talk/app/webrtc/dtmfsender.cc (left): https://codereview.webrtc.org/1590333004/diff/1/talk/app/webrtc/dtmfsender.cc#oldcode112 talk/app/webrtc/dtmfsender.cc:112: provider_->GetOnDestroyedSignal()->disconnect(this); This doesn't hurt anything, but it's pointless ...
4 years, 11 months ago (2016-01-16 00:55:10 UTC) #2
pthatcher1
lgtm
4 years, 11 months ago (2016-01-19 01:44:28 UTC) #3
honghaiz3
lgtm
4 years, 11 months ago (2016-01-19 17:57:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1590333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1590333004/1
4 years, 11 months ago (2016-01-20 20:32:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 22:30:47 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/057ecf01e4c2bc927481204192375dd5afd8d2f5 Cr-Commit-Position: refs/heads/master@{#11327}
4 years, 11 months ago (2016-01-20 22:30:59 UTC) #9
joachim
https://codereview.webrtc.org/1590333004/diff/1/talk/app/webrtc/webrtcsession_unittest.cc File talk/app/webrtc/webrtcsession_unittest.cc (right): https://codereview.webrtc.org/1590333004/diff/1/talk/app/webrtc/webrtcsession_unittest.cc#newcode1480 talk/app/webrtc/webrtcsession_unittest.cc:1480: bool session_destroyed_; Just driving by, this should IMHO be ...
4 years, 11 months ago (2016-01-21 13:10:54 UTC) #11
Taylor Brandstetter
4 years, 11 months ago (2016-01-21 18:21:07 UTC) #12
Message was sent while issue was closed. 
https://codereview.webrtc.org/1590333004/diff/1/talk/app/webrtc/webrtcsession...
File talk/app/webrtc/webrtcsession_unittest.cc (right):

https://codereview.webrtc.org/1590333004/diff/1/talk/app/webrtc/webrtcsession...
talk/app/webrtc/webrtcsession_unittest.cc:1480: bool session_destroyed_;
On 2016/01/21 13:10:54, joachim wrote:
> Just driving by, this should IMHO be initialized to "false" somewhere.

Good catch, thanks!

Powered by Google App Engine
This is Rietveld 408576698