Chromium Code Reviews| Index: talk/app/webrtc/dtmfsender.cc |
| diff --git a/talk/app/webrtc/dtmfsender.cc b/talk/app/webrtc/dtmfsender.cc |
| index 3b311df320d62c0c23630bc7a40306faf6b7032b..30e2ce3873deca75717e3a0a2037caf6fd4a88e3 100644 |
| --- a/talk/app/webrtc/dtmfsender.cc |
| +++ b/talk/app/webrtc/dtmfsender.cc |
| @@ -99,6 +99,8 @@ DtmfSender::DtmfSender(AudioTrackInterface* track, |
| inter_tone_gap_(kDtmfDefaultGapMs) { |
| ASSERT(track_ != NULL); |
| ASSERT(signaling_thread_ != NULL); |
| + // TODO(deadbeef): Once we can use shared_ptr and weak_ptr, |
| + // do that instead of relying on a "destroyed" signal. |
| if (provider_) { |
| ASSERT(provider_->GetOnDestroyedSignal() != NULL); |
| provider_->GetOnDestroyedSignal()->connect( |
| @@ -107,10 +109,6 @@ DtmfSender::DtmfSender(AudioTrackInterface* track, |
| } |
| DtmfSender::~DtmfSender() { |
| - if (provider_) { |
| - ASSERT(provider_->GetOnDestroyedSignal() != NULL); |
| - provider_->GetOnDestroyedSignal()->disconnect(this); |
|
Taylor Brandstetter
2016/01/16 00:55:10
This doesn't hurt anything, but it's pointless sin
|
| - } |
| StopSending(); |
| } |