Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: talk/app/webrtc/webrtcsession.cc

Issue 1590333004: Making WebRtcSession fire a destroyed signal. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/webrtcsession.cc
diff --git a/talk/app/webrtc/webrtcsession.cc b/talk/app/webrtc/webrtcsession.cc
index d8f76379c1b8925b537a9e83c3a0bf98c9c908f4..c6d1856f0353957224932aeb8e0c076e4ccdfaa9 100644
--- a/talk/app/webrtc/webrtcsession.cc
+++ b/talk/app/webrtc/webrtcsession.cc
@@ -590,6 +590,7 @@ WebRtcSession::~WebRtcSession() {
SignalDataChannelDestroyed();
channel_manager_->DestroyDataChannel(data_channel_.release());
}
+ SignalDestroyed();
LOG(LS_INFO) << "Session: " << id() << " is destroyed.";
}
@@ -1428,7 +1429,7 @@ bool WebRtcSession::InsertDtmf(const std::string& track_id,
}
sigslot::signal0<>* WebRtcSession::GetOnDestroyedSignal() {
- return &SignalVoiceChannelDestroyed;
+ return &SignalDestroyed;
}
bool WebRtcSession::SendData(const cricket::SendDataParams& params,

Powered by Google App Engine
This is Rietveld 408576698