Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1586183002: Revert of Update with new default boringssl no-aes cipher suites. Re-enable tests. (Closed)

Created:
4 years, 11 months ago by sprang_webrtc
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Update with new default boringssl no-aes cipher suites. Re-enable tests. (patchset #3 id:40001 of https://codereview.webrtc.org/1550773002/ ) Reason for revert: We're getting boringssl version conflicts. Reverting for now. Original issue's description: > Update with new default boringssl no-aes cipher suites. Re-enable tests. > > This undoes https://codereview.webrtc.org/1533253002 (except the DEPS part). > > BUG=webrtc:5381 > R=davidben@webrtc.org, henrika@webrtc.org > > Committed: https://crrev.com/31c8d2eac5aec977f584ab0ae5a1d457d674f101 > Cr-Commit-Position: refs/heads/master@{#11250} TBR=davidben@webrtc.org,henrika@webrtc.org,torbjorng@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5381 Committed: https://crrev.com/3542013f587f0858fb24fa8e554ec3c01a323da8 Cr-Commit-Position: refs/heads/master@{#11253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
sprang_webrtc
Created Revert of Update with new default boringssl no-aes cipher suites. Re-enable tests.
4 years, 11 months ago (2016-01-14 17:13:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586183002/1
4 years, 11 months ago (2016-01-14 17:13:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 17:14:06 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 17:14:10 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3542013f587f0858fb24fa8e554ec3c01a323da8
Cr-Commit-Position: refs/heads/master@{#11253}

Powered by Google App Engine
This is Rietveld 408576698