Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1533253002: Roll chromium_revision 1b6c421..db567a8 (365999:366304) (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
4 years, 12 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision 1b6c421..db567a8 (365999:366304) I had to disable some Dtls12Both tests failing under MSan (see bug). Notice those errors started happening in the range of https://boringssl.googlesource.com/boringssl.git/+log/afd565f..9f897b2 while this CL brings in an even newer BoringSSL (that still has the same problem). Change log: https://chromium.googlesource.com/chromium/src/+log/1b6c421..db567a8 Full diff: https://chromium.googlesource.com/chromium/src/+/1b6c421..db567a8 Changed dependencies: * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/afd565f..afe57cb * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/1019e45..1ccbf8f * src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/a676aa0..aee1b12 DEPS diff: https://chromium.googlesource.com/chromium/src/+/1b6c421..db567a8/DEPS No update to Clang. NOTRY=True BUG=webrtc:5381 TBR=torbjorng@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/2f042f26a3d0c062c43dc553058a286bd4dd8f19 Cr-Commit-Position: refs/heads/master@{#11095}

Patch Set 1 #

Patch Set 2 : Disabled failing tests under MSan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533253002/1
5 years ago (2015-12-20 19:02:53 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/6831)
5 years ago (2015-12-20 19:31:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533253002/20001
5 years ago (2015-12-20 20:21:19 UTC) #9
kjellander_webrtc
5 years ago (2015-12-20 20:21:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-20 20:25:16 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2f042f26a3d0c062c43dc553058a286bd4dd8f19 Cr-Commit-Position: refs/heads/master@{#11095}
5 years ago (2015-12-20 20:25:26 UTC) #14
torbjorng (webrtc)
It seems a bit rash to disable the entire set of tests instantiated by INSTANTIATE_TEST_CASE_P ...
5 years ago (2015-12-21 17:44:04 UTC) #15
kjellander_webrtc
On 2015/12/21 17:44:04, torbjorng (webrtc) wrote: > It seems a bit rash to disable the ...
5 years ago (2015-12-21 18:58:20 UTC) #16
torbjorng (webrtc)
I'll make the disabling more fine-grained unless I can fix this soon. I understand the ...
5 years ago (2015-12-21 19:24:00 UTC) #17
torbjorng (webrtc)
4 years, 12 months ago (2015-12-28 15:26:21 UTC) #18
Message was sent while issue was closed.
We re-enable tests in https://codereview.webrtc.org/1550773002.

Powered by Google App Engine
This is Rietveld 408576698