webrtc/modules/rtp_rtcp/include/rtp_rtcp.h - Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing.

Unified Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/call/call.cc ('K') | « webrtc/call/rtc_event_log_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_sender.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

diff --git a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

index 6a7022a94cc66bda08f0749b1c1761b0d7da1b08..0a90ea342e9af17564f35f51831acacf99170b20 100644

--- a/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

+++ b/webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

@@ -24,6 +24,7 @@ class ReceiveStatistics;

class RemoteBitrateEstimator;

class RtpReceiver;

class Transport;

+class RtcEventLog;

namespace rtcp {

stefan-webrtc 2016/01/11 13:12:59 Empty line above.

terelius 2016/01/11 15:04:03 Done.

class TransportFeedback;

}

@@ -73,6 +74,7 @@ class RtpRtcp : public Module {

BitrateStatisticsObserver* send_bitrate_observer;

FrameCountObserver* send_frame_count_observer;

SendSideDelayObserver* send_side_delay_observer;

+ RtcEventLog* event_log;

the sun 2016/01/11 12:36:16 = nullptr

stefan-webrtc 2016/01/11 13:12:59 I'd prefer not to mix "= nullptr" with initializin

terelius 2016/01/11 13:22:11 Yeah, I was just about to ask whether the I should

the sun 2016/01/11 13:40:22 That is already hard since we do not include *all*

terelius 2016/01/11 15:04:03 Added RTC_DISALLOW_COPY_AND_ASSIGN.

};