webrtc/modules/rtp_rtcp/source/rtcp_sender.h - Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1571283002: Fixes a bug which incorrectly logs incoming RTCP as outgoing. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/include/rtp_rtcp.h ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

index dd3aec4c9fa75eab0b1b6738825065a95c44dfff..85748c81d56d36a97c413dc51dd452adf5279ef5 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender.h

@@ -35,6 +35,7 @@ namespace webrtc {

class ModuleRtpRtcpImpl;

class RTCPReceiver;

+class RtcEventLog;

class NACKStringBuilder {

public:

@@ -77,6 +78,7 @@ class RTCPSender {

Clock* clock,

ReceiveStatistics* receive_statistics,

RtcpPacketTypeCounterObserver* packet_type_counter_observer,

+ RtcEventLog* event_log,

Transport* outgoing_transport);

virtual ~RTCPSender();

@@ -203,6 +205,7 @@ class RTCPSender {

Random random_ GUARDED_BY(critical_section_rtcp_sender_);

RtcpMode method_ GUARDED_BY(critical_section_rtcp_sender_);

+ RtcEventLog* event_log_;

the sun 2016/01/11 12:36:16 RtcEventLog* const event_log_ = nullptr;

terelius 2016/01/11 15:04:03 Added RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RTCPSende

Transport* const transport_;

rtc::scoped_ptr<CriticalSectionWrapper> critical_section_rtcp_sender_;