Fixes a bug which incorrectly logs incoming RTCP as outgoing.

webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
 #define WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
 
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "webrtc/modules/include/module.h"
 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
 
 namespace webrtc {
 // Forward declarations.
 class ReceiveStatistics;
 class RemoteBitrateEstimator;
 class RtpReceiver;
 class Transport;
+class RtcEventLog;
 namespace rtcp {

[stefan-webrtc, 2016/01/11 13:12:59]

Empty line above.

[terelius, 2016/01/11 15:04:03]

Done.

 class TransportFeedback;
 }
 
 class RtpRtcp : public Module {
  public:
   struct Configuration {
     Configuration();
 
    /*  id                   - Unique identifier of this RTP/RTCP module object
     *  audio                - True for a audio version of the RTP/RTCP module
@@ skipping 28 matching lines @@
     TransportFeedbackObserver* transport_feedback_callback;
     RtcpRttStats* rtt_stats;
     RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer;
     RtpAudioFeedback* audio_messages;
     RemoteBitrateEstimator* remote_bitrate_estimator;
     RtpPacketSender* paced_sender;
     TransportSequenceNumberAllocator* transport_sequence_number_allocator;
     BitrateStatisticsObserver* send_bitrate_observer;
     FrameCountObserver* send_frame_count_observer;
     SendSideDelayObserver* send_side_delay_observer;
+    RtcEventLog* event_log;

[the sun, 2016/01/11 12:36:16]

= nullptr

[stefan-webrtc, 2016/01/11 13:12:59]

I'd prefer not to mix "= nullptr" with initializing members in the constructor.

For video code I think we at some point decided against using this feature of
C++11 as it becomes harder to know if a parameter has been initialized or not by
only looking in the initializer list (basically you need to check both the .h
and the .cc).

[terelius, 2016/01/11 13:22:11]

Yeah, I was just about to ask whether the I should change all the other pointers
too. I think we should be consistent, at least within each file; either we
default all pointers to null or we leave all of them uninitialized.

[the sun, 2016/01/11 13:40:22]

That is already hard since we do not include *all* members in the ctor init list
(aggregate objects with default ctors are generally excluded). If we
consistently used class definition initialization, it would actually be easier
than now. Then, anything in a ctor init list could be assumed to be an override
of the default.
Agree it's better to be consistent.

If you prefer to use ctor init list, make sure to use
RTC_DISALLOW_IMPLICT_CONSTRUCTORS in the other classes where you added this
member.

[terelius, 2016/01/11 15:04:03]

Added RTC_DISALLOW_COPY_AND_ASSIGN.

   };
 
   /*
    *   Create a RTP/RTCP module object using the system clock.
    *
    *   configuration  - Configuration of the RTP/RTCP module.
    */
   static RtpRtcp* CreateRtpRtcp(const RtpRtcp::Configuration& configuration);
 
   /**************************************************************************
@@ skipping 558 matching lines @@
 
     /*
     *   send a request for a keyframe
     *
     *   return -1 on failure else 0
     */
     virtual int32_t RequestKeyFrame() = 0;
 };
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_