Update API for Objective-C RTCAudioTrack and RTCVideoTrack.

Update API for Objective-C RTCAudioTrack and RTCVideoTrack.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/ca91e38a3a4e43dbf0e1f21af005e8540904f829
Patch from Jon Hjelle <hjon@andyet.net>;.

Cr-Commit-Position: refs/heads/master@{#11350}

[hjon, 2015-12-31 00:56:02]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[hjon, 2015-12-31 00:56:03]

This will also require the following CLs before it will build properly:
- RTCPeerConnectionFactory (https://codereview.webrtc.org/1558473002/)
- RTCVideoRenderer (https://codereview.webrtc.org/1542473003)
- RTCVideoSource (https://codereview.webrtc.org/1546783002)

[hjon, 2016-01-14 00:41:35]

On 2015/12/31 00:56:03, hjon wrote:
> This will also require the following CLs before it will build properly:
> - RTCPeerConnectionFactory (https://codereview.webrtc.org/1558473002/)
> - RTCVideoRenderer (https://codereview.webrtc.org/1542473003)
> - RTCVideoSource (https://codereview.webrtc.org/1546783002)

That should actually be RTCVideoRendererAdapter
(https://codereview.webrtc.org/1533323003/), rather than RTCVideoRenderer.

Looking through this one again, I'm realizing there are similar issues to
RTCVideoSource/RTCMediaSource
(https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...)
in terms of designated initializers and subclasses. I've had the additional
thought that we could use doesNotRecognizeSelector: in subclasses where the
designated initializer of the superclass doesn't make as much sense. For
example, RTCAudioTrack could have an additional ctor initWithNativeAudioTrack
and for initWithNativeTrack we could call doesNotRecognizeSelector. We could
also do some type checking in initWithNativeTrack.

Thoughts?

[tkchin_webrtc, 2016-01-14 01:36:42]

On 2016/01/14 00:41:35, hjon wrote:
> On 2015/12/31 00:56:03, hjon wrote:
> > This will also require the following CLs before it will build properly:
> > - RTCPeerConnectionFactory (https://codereview.webrtc.org/1558473002/)
> > - RTCVideoRenderer (https://codereview.webrtc.org/1542473003)
> > - RTCVideoSource (https://codereview.webrtc.org/1546783002)
> 
> That should actually be RTCVideoRendererAdapter
> (https://codereview.webrtc.org/1533323003/), rather than RTCVideoRenderer.
> 
> Looking through this one again, I'm realizing there are similar issues to
> RTCVideoSource/RTCMediaSource
>
(https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...)
> in terms of designated initializers and subclasses. I've had the additional
> thought that we could use doesNotRecognizeSelector: in subclasses where the
> designated initializer of the superclass doesn't make as much sense. For
> example, RTCAudioTrack could have an additional ctor initWithNativeAudioTrack
> and for initWithNativeTrack we could call doesNotRecognizeSelector. We could
> also do some type checking in initWithNativeTrack.
> 
> Thoughts?

Yeah this suffers from the same problem as the other one where ref count is
ignored due to static cast. Let's figure out the other CL and come back to this
one.

[tkchin_webrtc, 2016-01-20 22:12:00]

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack.mm
File webrtc/api/objc/RTCVideoTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack...
webrtc/api/objc/RTCVideoTrack.mm:13: #import
"webrtc/api/objc/RTCVideoTrack+Private.h"
alphabetical

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack...
webrtc/api/objc/RTCVideoTrack.mm:44: - (instancetype)initWithTrack:
To avoid all these bits of nastiness of pointer conversion, let's just make the
superclass know about everything. Let's chat offline.

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack...
webrtc/api/objc/RTCVideoTrack.mm:98: return
static_cast<webrtc::VideoTrackInterface*>(self.nativeTrack.get());
space *

[hjon, 2016-01-21 00:23:43]

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack.mm
File webrtc/api/objc/RTCVideoTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack...
webrtc/api/objc/RTCVideoTrack.mm:13: #import
"webrtc/api/objc/RTCVideoTrack+Private.h"
On 2016/01/20 22:12:00, tkchin_webrtc wrote:
> alphabetical

Done.

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack...
webrtc/api/objc/RTCVideoTrack.mm:44: - (instancetype)initWithTrack:
On 2016/01/20 22:12:00, tkchin_webrtc wrote:
> To avoid all these bits of nastiness of pointer conversion, let's just make
the
> superclass know about everything. Let's chat offline.

Acknowledged.

https://codereview.webrtc.org/1553743003/diff/1/webrtc/api/objc/RTCVideoTrack...
webrtc/api/objc/RTCVideoTrack.mm:98: return
static_cast<webrtc::VideoTrackInterface*>(self.nativeTrack.get());
On 2016/01/20 22:12:00, tkchin_webrtc wrote:
> space *

Done.

[tkchin_webrtc, 2016-01-21 01:23:30]

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCAudioT...
File webrtc/api/objc/RTCAudioTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCAudioT...
webrtc/api/objc/RTCAudioTrack.mm:27: self =
return [self initWIth...] should be enough?

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCAudioT...
webrtc/api/objc/RTCAudioTrack.mm:37: self = [super
initWithNativeMediaTrack:nativeMediaTrack
This should follow normal super patterns?

if (self = [super initWith...]) {

}
return self

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:63: return
static_cast<webrtc::AudioTrackInterface *>(_nativeAudioTrack.get());
If we're static casting on the getter, might as well just not store it in
separate ivars and keep it in just _nativeMediaTrack. At which point, you might
as well move nativeAudioTrack to RTCAudioTrack instead and assert on the type.

So we keep the added type in the ctor, but otherwise keep things the way they
were.

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource.mm (right):

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource.mm:19: 
?

[hjon, 2016-01-21 19:53:27]

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCAudioT...
File webrtc/api/objc/RTCAudioTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCAudioT...
webrtc/api/objc/RTCAudioTrack.mm:27: self =
On 2016/01/21 01:23:30, tkchin_webrtc wrote:
> return [self initWIth...] should be enough?

Done.

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCAudioT...
webrtc/api/objc/RTCAudioTrack.mm:37: self = [super
initWithNativeMediaTrack:nativeMediaTrack
On 2016/01/21 01:23:30, tkchin_webrtc wrote:
> This should follow normal super patterns?
> 
> if (self = [super initWith...]) {
> 
> }
> return self

I think return self = [super initWith...]; should be sufficient here, since
there isn't any extra work to do?

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.mm:63: return
static_cast<webrtc::AudioTrackInterface *>(_nativeAudioTrack.get());
On 2016/01/21 01:23:30, tkchin_webrtc wrote:
> If we're static casting on the getter, might as well just not store it in
> separate ivars and keep it in just _nativeMediaTrack. At which point, you
might
> as well move nativeAudioTrack to RTCAudioTrack instead and assert on the type.
> 
> So we keep the added type in the ctor, but otherwise keep things the way they
> were.

This should be taken care of.

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource.mm (right):

https://codereview.webrtc.org/1553743003/diff/40001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource.mm:19: 
On 2016/01/21 01:23:30, tkchin_webrtc wrote:
> ?

Not sure what happened...removed.

[tkchin_webrtc, 2016-01-21 23:13:10]

lgtm
some nits

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCAudio...
File webrtc/api/objc/RTCAudioTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCAudio...
webrtc/api/objc/RTCAudioTrack.mm:24: std::string nativeID = [NSString
stdStringForString:trackId];
Id

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCAudio...
webrtc/api/objc/RTCAudioTrack.mm:32: type:(RTCMediaStreamTrackType)type {
align :

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCMedia...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCMedia...
webrtc/api/objc/RTCMediaStreamTrack.mm:58: type:(RTCMediaStreamTrackType)type {
align :

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCVideo...
File webrtc/api/objc/RTCVideoTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoTrack.mm:32: std::string nativeID = [NSString
stdStringForString:trackId];
nativeId

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoTrack.mm:64: NSAssert(adapter.videoRenderer != renderer,
align with (

[hjon, 2016-01-21 23:32:58]

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCAudio...
File webrtc/api/objc/RTCAudioTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCAudio...
webrtc/api/objc/RTCAudioTrack.mm:24: std::string nativeID = [NSString
stdStringForString:trackId];
On 2016/01/21 23:13:10, tkchin_webrtc wrote:
> Id

Done.

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCAudio...
webrtc/api/objc/RTCAudioTrack.mm:32: type:(RTCMediaStreamTrackType)type {
On 2016/01/21 23:13:10, tkchin_webrtc wrote:
> align :

Done.

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCMedia...
File webrtc/api/objc/RTCMediaStreamTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCMedia...
webrtc/api/objc/RTCMediaStreamTrack.mm:58: type:(RTCMediaStreamTrackType)type {
On 2016/01/21 23:13:10, tkchin_webrtc wrote:
> align :

Done.

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCVideo...
File webrtc/api/objc/RTCVideoTrack.mm (right):

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoTrack.mm:32: std::string nativeID = [NSString
stdStringForString:trackId];
On 2016/01/21 23:13:10, tkchin_webrtc wrote:
> nativeId

Done.

https://codereview.webrtc.org/1553743003/diff/120001/webrtc/api/objc/RTCVideo...
webrtc/api/objc/RTCVideoTrack.mm:64: NSAssert(adapter.videoRenderer != renderer,
On 2016/01/21 23:13:10, tkchin_webrtc wrote:
> align with (

Done.

[tkchin_webrtc, 2016-01-21 23:36:58]

Description was changed from

==========
Update API for Objective-C RTCAudioTrack and RTCVideoTrack.

BUG=
==========

to

==========
Update API for Objective-C RTCAudioTrack and RTCVideoTrack.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ca91e38a3a4e43dbf0e1f21af...
==========

[tkchin_webrtc, 2016-01-21 23:36:59]

Committed patchset #9 (id:160001) manually as
ca91e38a3a4e43dbf0e1f21af005e8540904f829 (presubmit successful).

[commit-bot: I haz the power, 2016-01-21 23:37:03]

Description was changed from

==========
Update API for Objective-C RTCAudioTrack and RTCVideoTrack.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ca91e38a3a4e43dbf0e1f21af...
==========

to

==========
Update API for Objective-C RTCAudioTrack and RTCVideoTrack.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/ca91e38a3a4e43dbf0e1f21af005e8540904f829
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11350}
==========

[commit-bot: I haz the power, 2016-01-21 23:37:04]

Patchset 9 (id:??) landed as
https://crrev.com/ca91e38a3a4e43dbf0e1f21af005e8540904f829
Cr-Commit-Position: refs/heads/master@{#11350}