Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: webrtc/api/objc/RTCAudioTrack.mm

Issue 1553743003: Update API for Objective-C RTCAudioTrack and RTCVideoTrack. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@updateRTCMediaStreamTrack
Patch Set: Improve comments a bit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #import "RTCAudioTrack.h"
12
13 #import "webrtc/api/objc/RTCAudioTrack+Private.h"
14 #import "webrtc/api/objc/RTCMediaStreamTrack+Private.h"
15 #import "webrtc/api/objc/RTCPeerConnectionFactory+Private.h"
16 #import "webrtc/base/objc/NSString+StdString.h"
17
18 @implementation RTCAudioTrack
19
20 - (instancetype)initWithFactory:(RTCPeerConnectionFactory *)factory
21 trackId:(NSString *)trackId {
22 NSParameterAssert(factory);
23 NSParameterAssert(trackId.length);
24 std::string nativeID = [NSString stdStringForString:trackId];
25 rtc::scoped_refptr<webrtc::AudioTrackInterface> track =
26 factory.nativeFactory->CreateAudioTrack(nativeID, nullptr);
27 self =
tkchin_webrtc 2016/01/21 01:23:30 return [self initWIth...] should be enough?
hjon 2016/01/21 19:53:27 Done.
28 [self initWithNativeMediaTrack:track type:RTCMediaStreamTrackTypeAudio];
29 return self;
30 }
31
32 - (instancetype)initWithNativeMediaTrack:
33 (rtc::scoped_refptr<webrtc::MediaStreamTrackInterface>)nativeMediaTrack
34 type:(RTCMediaStreamTrackType)type {
35 NSParameterAssert(nativeMediaTrack);
36 NSParameterAssert(type == RTCMediaStreamTrackTypeAudio);
37 self = [super initWithNativeMediaTrack:nativeMediaTrack
tkchin_webrtc 2016/01/21 01:23:30 This should follow normal super patterns? if (sel
hjon 2016/01/21 19:53:27 I think return self = [super initWith...]; should
38 type:type];
39 return self;
40 }
41
42 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698