Move RTCVideoSource to webrtc/api/objc.

Move RTCVideoSource to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/065aacc2490478062fc8128799d4ce90f5c8bcd6

[hjon, 2015-12-22 21:41:58]

hjon@andyet.net changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-01-11 21:32:34]

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource+Private.h (right):

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource+Private.h:25: 
Shouldn't we have a ctor here that takes a VideoSourceInterface instead? And
then calls the super's init?

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource.mm (right):

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource.mm:21: return
nit: use a local var and return that instead to avoid weird indentation

[hjon, 2016-01-11 22:45:08]

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource+Private.h (right):

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource+Private.h:25: 
On 2016/01/11 21:32:34, tkchin_webrtc wrote:
> Shouldn't we have a ctor here that takes a VideoSourceInterface instead? And
> then calls the super's init?

Done.

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource.mm (right):

https://codereview.webrtc.org/1546783002/diff/20001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource.mm:21: return
On 2016/01/11 21:32:34, tkchin_webrtc wrote:
> nit: use a local var and return that instead to avoid weird indentation

Done.

[hjon, 2016-01-11 22:47:40]

Updated comment.

[tkchin_webrtc, 2016-01-11 22:59:08]

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource+Private.h (right):

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource+Private.h:28:
(rtc::scoped_refptr<webrtc::VideoSourceInterface>)nativeVideoSource;
designated ctor

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource.mm (right):

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource.mm:23: return
rtc::scoped_refptr<webrtc::VideoSourceInterface>(videoSource);
aha okay. We can't do it this way because we will lose the refcount.
Please refactor the class so that RTCMediaSource is an abstract class with an
abstract method for nativeMediaSource. You can just use [self
doesNotRecognizeSelector:_cmd] in the RTCMediaSource implementation.

In the RTCVideoSource implementation, implement said abstract method to return
the rtc::VideoSourceInterface scoped ptr.

[hjon, 2016-01-12 00:25:16]

tkchin@ Based on our conversation, I think I got everything updated. Let me know
if I missed something or if you think anything should be implemented
differently.

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource+Private.h (right):

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource+Private.h:28:
(rtc::scoped_refptr<webrtc::VideoSourceInterface>)nativeVideoSource;
On 2016/01/11 22:59:08, tkchin_webrtc wrote:
> designated ctor

Done.

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
File webrtc/api/objc/RTCVideoSource.mm (right):

https://codereview.webrtc.org/1546783002/diff/60001/webrtc/api/objc/RTCVideoS...
webrtc/api/objc/RTCVideoSource.mm:23: return
rtc::scoped_refptr<webrtc::VideoSourceInterface>(videoSource);
On 2016/01/11 22:59:08, tkchin_webrtc wrote:
> aha okay. We can't do it this way because we will lose the refcount.
> Please refactor the class so that RTCMediaSource is an abstract class with an
> abstract method for nativeMediaSource. You can just use [self
> doesNotRecognizeSelector:_cmd] in the RTCMediaSource implementation.
> 
> In the RTCVideoSource implementation, implement said abstract method to return
> the rtc::VideoSourceInterface scoped ptr.

Done.

[tkchin_webrtc, 2016-01-13 02:26:27]

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource+Private.h (right):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource+Private.h:32:
rtc::scoped_refptr<webrtc::VideoSourceInterface> nativeVideoSource;
this shouldn't be here - only in RTCVideoSource

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.mm (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.mm:34: - (instancetype)initWithNativeMediaSource:
You know what, I think the safest thing to do is to keep two refcounts on the
ptr. Let's keep this ctor and have the subclass call it.

So both RTCMediaSource and RTCVideoSource will hold a refcount on the underlying
refptr.

Then we won't need to doesNotRecognizeSelector

[hjon, 2016-01-13 18:07:00]

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource+Private.h (right):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource+Private.h:32:
rtc::scoped_refptr<webrtc::VideoSourceInterface> nativeVideoSource;
On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> this shouldn't be here - only in RTCVideoSource

Done.

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.mm (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.mm:34: - (instancetype)initWithNativeMediaSource:
On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> You know what, I think the safest thing to do is to keep two refcounts on the
> ptr. Let's keep this ctor and have the subclass call it.
> 
> So both RTCMediaSource and RTCVideoSource will hold a refcount on the
underlying
> refptr.
> 
> Then we won't need to doesNotRecognizeSelector

If we keep this ctor as a designated initializer and RTCVideoSource has its own
designated initializer, it looks like RTCVideoSource will have to provide an
implementation of this ctor (based on the compiler error I get and what it says
in "Object Initialization" at
https://developer.apple.com/library/ios/releasenotes/ObjectiveC/Modernization...).
This seems a little awkward (at best) since it'd be possible to initialize an
RTCVideoSource with a MediaSourceInterface. I'm probably overlooking some
options, but offhand here are two ways we could go:

1. Just have RTCVideoSource and drop RTCMediaSource.
2. Don't mark a designated initializer for RTCVideoSource (it would still have
one we'd consider the designated initializer, but that way the compiler won't
complain about not implementing the designated initializer from RTCMediaSource).

I leans towards option 1 right now. What do you think?

[tkchin_webrtc, 2016-01-14 01:34:02]

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.h (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.h:27: - (instancetype)init NS_UNAVAILABLE;
restore this

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.mm (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.mm:34: - (instancetype)initWithNativeMediaSource:
On 2016/01/13 18:07:00, hjon wrote:
> On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> > You know what, I think the safest thing to do is to keep two refcounts on
the
> > ptr. Let's keep this ctor and have the subclass call it.
> > 
> > So both RTCMediaSource and RTCVideoSource will hold a refcount on the
> underlying
> > refptr.
> > 
> > Then we won't need to doesNotRecognizeSelector
> 
> If we keep this ctor as a designated initializer and RTCVideoSource has its
own
> designated initializer, it looks like RTCVideoSource will have to provide an
> implementation of this ctor (based on the compiler error I get and what it
says
> in "Object Initialization" at
>
https://developer.apple.com/library/ios/releasenotes/ObjectiveC/Modernization...).
> This seems a little awkward (at best) since it'd be possible to initialize an
> RTCVideoSource with a MediaSourceInterface. I'm probably overlooking some
> options, but offhand here are two ways we could go:
> 
> 1. Just have RTCVideoSource and drop RTCMediaSource.
> 2. Don't mark a designated initializer for RTCVideoSource (it would still have
> one we'd consider the designated initializer, but that way the compiler won't
> complain about not implementing the designated initializer from
RTCMediaSource).
> 
> I leans towards option 1 right now. What do you think?

The RTCVideoSource ctor will call [super initWithNativeMediaSource:] then also
set an ivar. Designated ctors need to chain. Am I missing something?

[hjon, 2016-01-14 17:04:24]

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.h (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.h:27: - (instancetype)init NS_UNAVAILABLE;
On 2016/01/14 01:34:02, tkchin_webrtc wrote:
> restore this

Done.

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.mm (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.mm:34: - (instancetype)initWithNativeMediaSource:
On 2016/01/14 01:34:02, tkchin_webrtc wrote:
> On 2016/01/13 18:07:00, hjon wrote:
> > On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> > > You know what, I think the safest thing to do is to keep two refcounts on
> the
> > > ptr. Let's keep this ctor and have the subclass call it.
> > > 
> > > So both RTCMediaSource and RTCVideoSource will hold a refcount on the
> > underlying
> > > refptr.
> > > 
> > > Then we won't need to doesNotRecognizeSelector
> > 
> > If we keep this ctor as a designated initializer and RTCVideoSource has its
> own
> > designated initializer, it looks like RTCVideoSource will have to provide an
> > implementation of this ctor (based on the compiler error I get and what it
> says
> > in "Object Initialization" at
> >
>
https://developer.apple.com/library/ios/releasenotes/ObjectiveC/Modernization...).
> > This seems a little awkward (at best) since it'd be possible to initialize
an
> > RTCVideoSource with a MediaSourceInterface. I'm probably overlooking some
> > options, but offhand here are two ways we could go:
> > 
> > 1. Just have RTCVideoSource and drop RTCMediaSource.
> > 2. Don't mark a designated initializer for RTCVideoSource (it would still
have
> > one we'd consider the designated initializer, but that way the compiler
won't
> > complain about not implementing the designated initializer from
> RTCMediaSource).
> > 
> > I leans towards option 1 right now. What do you think?
> 
> The RTCVideoSource ctor will call [super initWithNativeMediaSource:] then also
> set an ivar. Designated ctors need to chain. Am I missing something?

Let me think through this "out loud" to work through and make sure we're on the
same page.

RTCMediaSource will have a designated initializer initWithNativeMediaSource that
will set an ivar.

RTCVideoSource will have a designated initializer initWithNativeVideoSource that
will call [super initWithNativeMediaSource] and set an ivar. It will also
inherit initWithNativeMediaSource.

The docs say, "If a class provides one or more designated initializers, it must
implement all of the designated initializers of its superclass." So
RTCVideoSource will need to provide its own implementation of
initWithNativeMediaSource. This seems problematic to me as I don't think we want
to initialize an RTCVideoSource with an arbitrary media source. Checking types
would be an option, though.

Even if RTCVideoSource doesn't have a distinct designated initializer (and
therefore isn't required to implement initWithNativeMediaSource), it still
inherits initWithNativeMediaSource. The default implementation might be fine. I
think the only issue there is that nativeVideoSource will be NULL.

[tkchin_webrtc, 2016-01-14 22:27:41]

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.mm (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.mm:34: - (instancetype)initWithNativeMediaSource:
On 2016/01/14 17:04:24, hjon wrote:
> On 2016/01/14 01:34:02, tkchin_webrtc wrote:
> > On 2016/01/13 18:07:00, hjon wrote:
> > > On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> > > > You know what, I think the safest thing to do is to keep two refcounts
on
> > the
> > > > ptr. Let's keep this ctor and have the subclass call it.
> > > > 
> > > > So both RTCMediaSource and RTCVideoSource will hold a refcount on the
> > > underlying
> > > > refptr.
> > > > 
> > > > Then we won't need to doesNotRecognizeSelector
> > > 
> > > If we keep this ctor as a designated initializer and RTCVideoSource has
its
> > own
> > > designated initializer, it looks like RTCVideoSource will have to provide
an
> > > implementation of this ctor (based on the compiler error I get and what it
> > says
> > > in "Object Initialization" at
> > >
> >
>
https://developer.apple.com/library/ios/releasenotes/ObjectiveC/Modernization...).
> > > This seems a little awkward (at best) since it'd be possible to initialize
> an
> > > RTCVideoSource with a MediaSourceInterface. I'm probably overlooking some
> > > options, but offhand here are two ways we could go:
> > > 
> > > 1. Just have RTCVideoSource and drop RTCMediaSource.
> > > 2. Don't mark a designated initializer for RTCVideoSource (it would still
> have
> > > one we'd consider the designated initializer, but that way the compiler
> won't
> > > complain about not implementing the designated initializer from
> > RTCMediaSource).
> > > 
> > > I leans towards option 1 right now. What do you think?
> > 
> > The RTCVideoSource ctor will call [super initWithNativeMediaSource:] then
also
> > set an ivar. Designated ctors need to chain. Am I missing something?
> 
> Let me think through this "out loud" to work through and make sure we're on
the
> same page.
> 
> RTCMediaSource will have a designated initializer initWithNativeMediaSource
that
> will set an ivar.
> 
> RTCVideoSource will have a designated initializer initWithNativeVideoSource
that
> will call [super initWithNativeMediaSource] and set an ivar. It will also
> inherit initWithNativeMediaSource.
> 
> The docs say, "If a class provides one or more designated initializers, it
must
> implement all of the designated initializers of its superclass." So
> RTCVideoSource will need to provide its own implementation of
> initWithNativeMediaSource. This seems problematic to me as I don't think we
want
> to initialize an RTCVideoSource with an arbitrary media source. Checking types
> would be an option, though.
> 
> Even if RTCVideoSource doesn't have a distinct designated initializer (and
> therefore isn't required to implement initWithNativeMediaSource), it still
> inherits initWithNativeMediaSource. The default implementation might be fine.
I
> think the only issue there is that nativeVideoSource will be NULL.

Aha I gotcha. Sorry, I didn't think it through. Also, I realized that the old
static cast method is technically safe, because ref counts are stored on the
object. For whatever reason I thought that wasn't true.

But yes, let's go with option 1 and kill RTCMediaSource. We don't need it.

[hjon, 2016-01-14 23:18:10]

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaSource.mm (left):

https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaSource.mm:34: - (instancetype)initWithNativeMediaSource:
On 2016/01/14 22:27:41, tkchin_webrtc wrote:
> On 2016/01/14 17:04:24, hjon wrote:
> > On 2016/01/14 01:34:02, tkchin_webrtc wrote:
> > > On 2016/01/13 18:07:00, hjon wrote:
> > > > On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> > > > > You know what, I think the safest thing to do is to keep two refcounts
> on
> > > the
> > > > > ptr. Let's keep this ctor and have the subclass call it.
> > > > > 
> > > > > So both RTCMediaSource and RTCVideoSource will hold a refcount on the
> > > > underlying
> > > > > refptr.
> > > > > 
> > > > > Then we won't need to doesNotRecognizeSelector
> > > > 
> > > > If we keep this ctor as a designated initializer and RTCVideoSource has
> its
> > > own
> > > > designated initializer, it looks like RTCVideoSource will have to
provide
> an
> > > > implementation of this ctor (based on the compiler error I get and what
it
> > > says
> > > > in "Object Initialization" at
> > > >
> > >
> >
>
https://developer.apple.com/library/ios/releasenotes/ObjectiveC/Modernization...).
> > > > This seems a little awkward (at best) since it'd be possible to
initialize
> > an
> > > > RTCVideoSource with a MediaSourceInterface. I'm probably overlooking
some
> > > > options, but offhand here are two ways we could go:
> > > > 
> > > > 1. Just have RTCVideoSource and drop RTCMediaSource.
> > > > 2. Don't mark a designated initializer for RTCVideoSource (it would
still
> > have
> > > > one we'd consider the designated initializer, but that way the compiler
> > won't
> > > > complain about not implementing the designated initializer from
> > > RTCMediaSource).
> > > > 
> > > > I leans towards option 1 right now. What do you think?
> > > 
> > > The RTCVideoSource ctor will call [super initWithNativeMediaSource:] then
> also
> > > set an ivar. Designated ctors need to chain. Am I missing something?
> > 
> > Let me think through this "out loud" to work through and make sure we're on
> the
> > same page.
> > 
> > RTCMediaSource will have a designated initializer initWithNativeMediaSource
> that
> > will set an ivar.
> > 
> > RTCVideoSource will have a designated initializer initWithNativeVideoSource
> that
> > will call [super initWithNativeMediaSource] and set an ivar. It will also
> > inherit initWithNativeMediaSource.
> > 
> > The docs say, "If a class provides one or more designated initializers, it
> must
> > implement all of the designated initializers of its superclass." So
> > RTCVideoSource will need to provide its own implementation of
> > initWithNativeMediaSource. This seems problematic to me as I don't think we
> want
> > to initialize an RTCVideoSource with an arbitrary media source. Checking
types
> > would be an option, though.
> > 
> > Even if RTCVideoSource doesn't have a distinct designated initializer (and
> > therefore isn't required to implement initWithNativeMediaSource), it still
> > inherits initWithNativeMediaSource. The default implementation might be
fine.
> I
> > think the only issue there is that nativeVideoSource will be NULL.
> 
> Aha I gotcha. Sorry, I didn't think it through. Also, I realized that the old
> static cast method is technically safe, because ref counts are stored on the
> object. For whatever reason I thought that wasn't true.
> 
> But yes, let's go with option 1 and kill RTCMediaSource. We don't need it.
> 

It was a good exercise to think through it again and be sure I hadn't missed
something, either. :-)

And good to know re: static cast.

[tkchin_webrtc, 2016-01-20 21:16:07]

On 2016/01/14 23:18:10, hjon wrote:
>
https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
> File webrtc/api/objc/RTCMediaSource.mm (left):
> 
>
https://codereview.webrtc.org/1546783002/diff/80001/webrtc/api/objc/RTCMediaS...
> webrtc/api/objc/RTCMediaSource.mm:34: -
(instancetype)initWithNativeMediaSource:
> On 2016/01/14 22:27:41, tkchin_webrtc wrote:
> > On 2016/01/14 17:04:24, hjon wrote:
> > > On 2016/01/14 01:34:02, tkchin_webrtc wrote:
> > > > On 2016/01/13 18:07:00, hjon wrote:
> > > > > On 2016/01/13 02:26:27, tkchin_webrtc wrote:
> > > > > > You know what, I think the safest thing to do is to keep two
refcounts
> > on
> > > > the
> > > > > > ptr. Let's keep this ctor and have the subclass call it.
> > > > > > 
> > > > > > So both RTCMediaSource and RTCVideoSource will hold a refcount on
the
> > > > > underlying
> > > > > > refptr.
> > > > > > 
> > > > > > Then we won't need to doesNotRecognizeSelector
> > > > > 
> > > > > If we keep this ctor as a designated initializer and RTCVideoSource
has
> > its
> > > > own
> > > > > designated initializer, it looks like RTCVideoSource will have to
> provide
> > an
> > > > > implementation of this ctor (based on the compiler error I get and
what
> it
> > > > says
> > > > > in "Object Initialization" at
> > > > >
> > > >
> > >
> >
>
https://developer.apple.com/library/ios/releasenotes/ObjectiveC/Modernization...).
> > > > > This seems a little awkward (at best) since it'd be possible to
> initialize
> > > an
> > > > > RTCVideoSource with a MediaSourceInterface. I'm probably overlooking
> some
> > > > > options, but offhand here are two ways we could go:
> > > > > 
> > > > > 1. Just have RTCVideoSource and drop RTCMediaSource.
> > > > > 2. Don't mark a designated initializer for RTCVideoSource (it would
> still
> > > have
> > > > > one we'd consider the designated initializer, but that way the
compiler
> > > won't
> > > > > complain about not implementing the designated initializer from
> > > > RTCMediaSource).
> > > > > 
> > > > > I leans towards option 1 right now. What do you think?
> > > > 
> > > > The RTCVideoSource ctor will call [super initWithNativeMediaSource:]
then
> > also
> > > > set an ivar. Designated ctors need to chain. Am I missing something?
> > > 
> > > Let me think through this "out loud" to work through and make sure we're
on
> > the
> > > same page.
> > > 
> > > RTCMediaSource will have a designated initializer
initWithNativeMediaSource
> > that
> > > will set an ivar.
> > > 
> > > RTCVideoSource will have a designated initializer
initWithNativeVideoSource
> > that
> > > will call [super initWithNativeMediaSource] and set an ivar. It will also
> > > inherit initWithNativeMediaSource.
> > > 
> > > The docs say, "If a class provides one or more designated initializers, it
> > must
> > > implement all of the designated initializers of its superclass." So
> > > RTCVideoSource will need to provide its own implementation of
> > > initWithNativeMediaSource. This seems problematic to me as I don't think
we
> > want
> > > to initialize an RTCVideoSource with an arbitrary media source. Checking
> types
> > > would be an option, though.
> > > 
> > > Even if RTCVideoSource doesn't have a distinct designated initializer (and
> > > therefore isn't required to implement initWithNativeMediaSource), it still
> > > inherits initWithNativeMediaSource. The default implementation might be
> fine.
> > I
> > > think the only issue there is that nativeVideoSource will be NULL.
> > 
> > Aha I gotcha. Sorry, I didn't think it through. Also, I realized that the
old
> > static cast method is technically safe, because ref counts are stored on the
> > object. For whatever reason I thought that wasn't true.
> > 
> > But yes, let's go with option 1 and kill RTCMediaSource. We don't need it.
> > 
> 
> It was a good exercise to think through it again and be sure I hadn't missed
> something, either. :-)
> 
> And good to know re: static cast.

lgtm

[commit-bot: I haz the power, 2016-01-20 21:25:58]

Description was changed from

==========
Move RTCVideoSource to webrtc/api/objc.

BUG=
==========

to

==========
Move RTCVideoSource to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/065aacc2490478062fc8128799d4ce90f5c8bcd6
Patch from Jon Hjelle <hjon@andyet.net>.

Cr-Commit-Position: refs/heads/master@{#11325}
==========

[tkchin_webrtc, 2016-01-20 21:25:58]

Description was changed from

==========
Move RTCVideoSource to webrtc/api/objc.

BUG=
==========

to

==========
Move RTCVideoSource to webrtc/api/objc.

BUG=
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/065aacc2490478062fc812879...
==========

[commit-bot: I haz the power, 2016-01-20 21:25:58]

Patchset 7 (id:??) landed as
https://crrev.com/065aacc2490478062fc8128799d4ce90f5c8bcd6
Cr-Commit-Position: refs/heads/master@{#11325}

[tkchin_webrtc, 2016-01-20 21:25:59]

Committed patchset #7 (id:120001) manually as
065aacc2490478062fc8128799d4ce90f5c8bcd6 (presubmit successful).