Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1559753002: Move RTCAVFoundationCapturer to webrtc/api/objc. (Closed)

Created:
4 years, 11 months ago by hjon
Modified:
4 years, 11 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@updateRTCVideoSource
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTCAVFoundationCapturer to webrtc/api/objc. BUG= R=tkchin@webrtc.org Committed: https://crrev.com/7ac8babbc6f2ed4b0395ecaaf153ec91d71560d5 Patch from Jon Hjelle <hjon@andyet.net>;. Cr-Commit-Position: refs/heads/master@{#11348}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes from feedback #

Patch Set 3 : Updates from upstream #

Total comments: 8

Patch Set 4 : Update from feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -57 lines) Patch
M webrtc/api/BUILD.gn View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCAVFoundationVideoSource.h View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCAVFoundationVideoSource.mm View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
A + webrtc/api/objc/RTCAVFoundationVideoSource+Private.h View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
A webrtc/api/objc/avfoundationvideocapturer.h View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A + webrtc/api/objc/avfoundationvideocapturer.mm View 1 2 3 16 chunks +35 lines, -52 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hjon
This will also require the following CLs before it will build properly: - RTCPeerConnectionFactory (https://codereview.webrtc.org/1558473002/) ...
4 years, 11 months ago (2015-12-31 17:09:45 UTC) #2
tkchin_webrtc
https://codereview.webrtc.org/1559753002/diff/1/webrtc/api/objc/RTCAVFoundationVideoSource.mm File webrtc/api/objc/RTCAVFoundationVideoSource.mm (right): https://codereview.webrtc.org/1559753002/diff/1/webrtc/api/objc/RTCAVFoundationVideoSource.mm#newcode48 webrtc/api/objc/RTCAVFoundationVideoSource.mm:48: static_cast<webrtc::AVFoundationVideoCapturer*>(capturer); update * https://codereview.webrtc.org/1559753002/diff/1/webrtc/api/objc/avfoundationvideocapturer.h File webrtc/api/objc/avfoundationvideocapturer.h (right): https://codereview.webrtc.org/1559753002/diff/1/webrtc/api/objc/avfoundationvideocapturer.h#newcode20 webrtc/api/objc/avfoundationvideocapturer.h:20: ...
4 years, 11 months ago (2016-01-14 01:45:46 UTC) #3
hjon
https://codereview.webrtc.org/1559753002/diff/1/webrtc/api/objc/RTCAVFoundationVideoSource.mm File webrtc/api/objc/RTCAVFoundationVideoSource.mm (right): https://codereview.webrtc.org/1559753002/diff/1/webrtc/api/objc/RTCAVFoundationVideoSource.mm#newcode48 webrtc/api/objc/RTCAVFoundationVideoSource.mm:48: static_cast<webrtc::AVFoundationVideoCapturer*>(capturer); On 2016/01/14 01:45:46, tkchin_webrtc wrote: > update * ...
4 years, 11 months ago (2016-01-14 19:54:12 UTC) #4
tkchin_webrtc
lgtm https://codereview.webrtc.org/1559753002/diff/40001/webrtc/api/objc/RTCAVFoundationVideoSource.h File webrtc/api/objc/RTCAVFoundationVideoSource.h (right): https://codereview.webrtc.org/1559753002/diff/40001/webrtc/api/objc/RTCAVFoundationVideoSource.h#newcode19 webrtc/api/objc/RTCAVFoundationVideoSource.h:19: // RTCAVFoundationVideoSource is a video source that uses ...
4 years, 11 months ago (2016-01-20 21:51:12 UTC) #5
hjon
https://codereview.webrtc.org/1559753002/diff/40001/webrtc/api/objc/RTCAVFoundationVideoSource.h File webrtc/api/objc/RTCAVFoundationVideoSource.h (right): https://codereview.webrtc.org/1559753002/diff/40001/webrtc/api/objc/RTCAVFoundationVideoSource.h#newcode19 webrtc/api/objc/RTCAVFoundationVideoSource.h:19: // RTCAVFoundationVideoSource is a video source that uses On ...
4 years, 11 months ago (2016-01-20 22:25:34 UTC) #6
tkchin_webrtc
Committed patchset #4 (id:60001) manually as 7ac8babbc6f2ed4b0395ecaaf153ec91d71560d5 (presubmit successful).
4 years, 11 months ago (2016-01-21 19:45:07 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:45:10 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/7ac8babbc6f2ed4b0395ecaaf153ec91d71560d5
Cr-Commit-Position: refs/heads/master@{#11348}

Powered by Google App Engine
This is Rietveld 408576698