Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1543033003: Update API for Objective-C RTCMediaConstraints. (Closed)

Created:
5 years ago by hjon
Modified:
4 years, 11 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@updateRTCIceCandidate
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update API for Objective-C RTCMediaConstraints. BUG= Committed: https://crrev.com/6f5ca080b87e720c0731f4b5ccb028aa5a234b5f Cr-Commit-Position: refs/heads/master@{#11172}

Patch Set 1 #

Patch Set 2 : Changes from feedback #

Patch Set 3 : Changes from feedback #

Patch Set 4 : Use scoped_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -6 lines) Patch
M webrtc/api/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/api_tests.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/api/objc/RTCMediaConstraints.h View 1 chunk +8 lines, -6 lines 0 comments Download
A webrtc/api/objc/RTCMediaConstraints.mm View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download
A webrtc/api/objc/RTCMediaConstraints+Private.h View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A webrtc/api/objctests/RTCMediaConstraintsTest.mm View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hjon
5 years ago (2015-12-22 20:25:03 UTC) #2
tkchin_webrtc
lgtm
4 years, 11 months ago (2016-01-06 22:27:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543033003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543033003/60001
4 years, 11 months ago (2016-01-06 22:28:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 11 months ago (2016-01-07 00:28:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543033003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543033003/60001
4 years, 11 months ago (2016-01-07 17:24:06 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-07 17:29:33 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 17:29:44 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6f5ca080b87e720c0731f4b5ccb028aa5a234b5f
Cr-Commit-Position: refs/heads/master@{#11172}

Powered by Google App Engine
This is Rietveld 408576698