Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1538673002: Adding a MediaStream parameter to createSender. (Closed)

Created:
5 years ago by Taylor Brandstetter
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding a MediaStream parameter to createSender. This will allow an app to create senders with the same stream id, without SDP munging. Committed: https://crrev.com/bd7d8f7e2b824a887aa12236cb6185d446d7da61 Cr-Commit-Position: refs/heads/master@{#11092}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Just take a string as a parameter, for simplicity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnection.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionproxy.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Taylor Brandstetter
5 years ago (2015-12-17 21:27:20 UTC) #2
pthatcher1
https://codereview.webrtc.org/1538673002/diff/1/talk/app/webrtc/peerconnection.cc File talk/app/webrtc/peerconnection.cc (right): https://codereview.webrtc.org/1538673002/diff/1/talk/app/webrtc/peerconnection.cc#newcode829 talk/app/webrtc/peerconnection.cc:829: new_sender->set_stream_id(stream->label()); Since this is non-standard anyway, would it make ...
5 years ago (2015-12-17 22:04:11 UTC) #3
Taylor Brandstetter
https://codereview.webrtc.org/1538673002/diff/1/talk/app/webrtc/peerconnection.cc File talk/app/webrtc/peerconnection.cc (right): https://codereview.webrtc.org/1538673002/diff/1/talk/app/webrtc/peerconnection.cc#newcode829 talk/app/webrtc/peerconnection.cc:829: new_sender->set_stream_id(stream->label()); On 2015/12/17 22:04:11, pthatcher1 wrote: > Since this ...
5 years ago (2015-12-18 01:49:06 UTC) #4
pthatcher1
lgtm
5 years ago (2015-12-18 02:31:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538673002/20001
5 years ago (2015-12-18 18:07:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
5 years ago (2015-12-18 20:08:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538673002/20001
5 years ago (2015-12-18 23:55:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-19 00:58:49 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-19 00:58:57 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bd7d8f7e2b824a887aa12236cb6185d446d7da61
Cr-Commit-Position: refs/heads/master@{#11092}

Powered by Google App Engine
This is Rietveld 408576698