talk/app/webrtc/peerconnection_unittest.cc - Issue 1538673002: Adding a MediaStream parameter to createSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnection_unittest.cc

Issue 1538673002: Adding a MediaStream parameter to createSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Just take a string as a parameter, for simplicity. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/peerconnection_unittest.cc

diff --git a/talk/app/webrtc/peerconnection_unittest.cc b/talk/app/webrtc/peerconnection_unittest.cc

index 49f450025af1ac8f916673cafafecf24585bcc47..0c4b8bcad1562fadd7ebaf23f6764aa594cc5a8a 100644

--- a/talk/app/webrtc/peerconnection_unittest.cc

+++ b/talk/app/webrtc/peerconnection_unittest.cc

@@ -1797,8 +1797,10 @@ TEST_F(P2PTestConductor, DISABLED_LocalP2PTestWithVideoDecoderFactory) {

// received end-to-end.

TEST_F(P2PTestConductor, EarlyWarmupTest) {

ASSERT_TRUE(CreateTestClients());

- auto audio_sender = initializing_client()->pc()->CreateSender("audio");

- auto video_sender = initializing_client()->pc()->CreateSender("video");

+ auto audio_sender =

+ initializing_client()->pc()->CreateSender("audio", "stream_id");

+ auto video_sender =

+ initializing_client()->pc()->CreateSender("video", "stream_id");

initializing_client()->Negotiate();

// Wait for ICE connection to complete, without any tracks.

// Note that the receiving client WILL (in HandleIncomingOffer) create

« no previous file with comments | « talk/app/webrtc/peerconnection.cc ('k') | talk/app/webrtc/peerconnectioninterface.h » ('j') | no next file with comments »