Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1538673002: Adding a MediaStream parameter to createSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Just take a string as a parameter, for simplicity. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 // remote peer is notified. 331 // remote peer is notified.
332 virtual void RemoveStream(MediaStreamInterface* stream) = 0; 332 virtual void RemoveStream(MediaStreamInterface* stream) = 0;
333 333
334 // Returns pointer to the created DtmfSender on success. 334 // Returns pointer to the created DtmfSender on success.
335 // Otherwise returns NULL. 335 // Otherwise returns NULL.
336 virtual rtc::scoped_refptr<DtmfSenderInterface> CreateDtmfSender( 336 virtual rtc::scoped_refptr<DtmfSenderInterface> CreateDtmfSender(
337 AudioTrackInterface* track) = 0; 337 AudioTrackInterface* track) = 0;
338 338
339 // TODO(deadbeef): Make these pure virtual once all subclasses implement them. 339 // TODO(deadbeef): Make these pure virtual once all subclasses implement them.
340 // |kind| must be "audio" or "video". 340 // |kind| must be "audio" or "video".
341 // |stream_id| is used to populate the msid attribute; if empty, one will
342 // be generated automatically.
341 virtual rtc::scoped_refptr<RtpSenderInterface> CreateSender( 343 virtual rtc::scoped_refptr<RtpSenderInterface> CreateSender(
342 const std::string& kind) { 344 const std::string& kind,
345 const std::string& stream_id) {
343 return rtc::scoped_refptr<RtpSenderInterface>(); 346 return rtc::scoped_refptr<RtpSenderInterface>();
344 } 347 }
345 348
346 virtual std::vector<rtc::scoped_refptr<RtpSenderInterface>> GetSenders() 349 virtual std::vector<rtc::scoped_refptr<RtpSenderInterface>> GetSenders()
347 const { 350 const {
348 return std::vector<rtc::scoped_refptr<RtpSenderInterface>>(); 351 return std::vector<rtc::scoped_refptr<RtpSenderInterface>>();
349 } 352 }
350 353
351 virtual std::vector<rtc::scoped_refptr<RtpReceiverInterface>> GetReceivers() 354 virtual std::vector<rtc::scoped_refptr<RtpReceiverInterface>> GetReceivers()
352 const { 355 const {
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 CreatePeerConnectionFactory( 681 CreatePeerConnectionFactory(
679 rtc::Thread* worker_thread, 682 rtc::Thread* worker_thread,
680 rtc::Thread* signaling_thread, 683 rtc::Thread* signaling_thread,
681 AudioDeviceModule* default_adm, 684 AudioDeviceModule* default_adm,
682 cricket::WebRtcVideoEncoderFactory* encoder_factory, 685 cricket::WebRtcVideoEncoderFactory* encoder_factory,
683 cricket::WebRtcVideoDecoderFactory* decoder_factory); 686 cricket::WebRtcVideoDecoderFactory* decoder_factory);
684 687
685 } // namespace webrtc 688 } // namespace webrtc
686 689
687 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 690 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698