Use an explicit identifier in Config

Use an explicit identifier in Config

This let's us use them to configure them when using WebRTC as an external library. One use case where this is necessary is in the Android OS.

Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
Cr-Commit-Position: refs/heads/master@{#11231}

[aluebs-webrtc, 2015-12-19 01:15:31]

aluebs@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, stefan@webrtc.org, tommi@webrtc.org

[tommi (sloooow) - chröme, 2015-12-19 09:04:29]

tommi@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2015-12-19 09:04:30]

I'm having problems getting what this is about from the description alone. Can
you point me to a doc or bug with more information?

[aluebs-webrtc, 2016-01-12 01:37:35]

As suggested by tommi, I made a centralized enum for all identifiers, where they
can be added at the end or deprecated (not removed or changed order to maintain
binary compatibility) and now they have readable names. PTAL.

[tommi, 2016-01-12 11:43:14]

lgtm

[hlundin-webrtc, 2016-01-12 15:23:38]

LGTM with one optional suggestion.

https://codereview.webrtc.org/1538643004/diff/20001/webrtc/common.h
File webrtc/common.h (right):

https://codereview.webrtc.org/1538643004/diff/20001/webrtc/common.h#newcode23
webrtc/common.h:23: kMyExperiment,
kMyExperiment and kAlgo1CostFunction are only used in the unit tests for the
Config itself. I suggest you name them such that this is clear, e.g.,
kMyExperimentForTest, or something similar.

[aluebs-webrtc, 2016-01-12 18:37:56]

https://codereview.webrtc.org/1538643004/diff/20001/webrtc/common.h
File webrtc/common.h (right):

https://codereview.webrtc.org/1538643004/diff/20001/webrtc/common.h#newcode23
webrtc/common.h:23: kMyExperiment,
On 2016/01/12 15:23:38, hlundin-webrtc wrote:
> kMyExperiment and kAlgo1CostFunction are only used in the unit tests for the
> Config itself. I suggest you name them such that this is clear, e.g.,
> kMyExperimentForTest, or something similar.

Great suggestion. Done.

[aluebs-webrtc, 2016-01-12 18:38:04]

The CQ bit was checked by aluebs@webrtc.org

[aluebs-webrtc, 2016-01-12 18:38:05]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1538643004/#ps40001 (title:
"Naming")

[commit-bot: I haz the power, 2016-01-12 18:38:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538643004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538643004/40001

[commit-bot: I haz the power, 2016-01-12 18:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 18:39:46]

Try jobs failed on following builders:
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/6348)

[aluebs-webrtc, 2016-01-13 00:49:33]

The CQ bit was checked by aluebs@webrtc.org

[aluebs-webrtc, 2016-01-13 00:49:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1538643004/#ps60001 (title:
"Suppress Chrome's Clang plugins warnings for webrtc_common")

[commit-bot: I haz the power, 2016-01-13 00:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538643004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538643004/60001

[commit-bot: I haz the power, 2016-01-13 02:50:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-13 02:50:37]

Description was changed from

==========
Use an explicit identifier in Config

This let's us use them to configure them when using WebRTC as an external
library. One use case where this is necessary is in the Android OS.
==========

to

==========
Use an explicit identifier in Config

This let's us use them to configure them when using WebRTC as an external
library. One use case where this is necessary is in the Android OS.

Committed: https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
Cr-Commit-Position: refs/heads/master@{#11231}
==========

[commit-bot: I haz the power, 2016-01-13 02:50:38]

Patchset 4 (id:??) landed as
https://crrev.com/25249d92d3cf105bcc7b684c8924ccdbc9afcb93
Cr-Commit-Position: refs/heads/master@{#11231}

[tommi, 2016-01-13 16:11:21]

I need to revert this unfortunately since it's causing roll problems

https://codereview.webrtc.org/1538643004/diff/60001/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/1538643004/diff/60001/webrtc/BUILD.gn#newcode245
webrtc/BUILD.gn:245: configs -= [ "//build/config/clang:find_bad_constructs" ]
This line triggers the following error when trying to roll into Chrome:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release
'--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false
is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1
dcheck_always_on=true' --check
--runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

[tommi, 2016-01-13 16:11:46]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/1586563003/ by tommi@webrtc.org.

The reason for reverting is: Reverting due to problem with roll:

/b/build/slave/linux/build/src/buildtools/linux64/gn gen //out/Release
'--args=ffmpeg_branding="Chrome" proprietary_codecs=true is_debug=false
is_component_build=false use_goma=true goma_dir="/b/build/goma" symbol_level=1
dcheck_always_on=true' --check
--runtime-deps-list-file=/b/build/slave/linux/build/src/out/Release/runtime_deps
  -> returned 1
ERROR at //third_party/webrtc/BUILD.gn:245:18: Item not found
    configs -= [ "//build/config/clang:find_bad_constructs" ]
                 ^-----------------------------------------
You were trying to remove "//build/config/clang:find_bad_constructs"
from the list but it wasn't there.
GN gen failed: 1
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@.