webrtc/test/common_unittest.cc - Issue 1538643004: Use an explicit identifier in Config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/test/common_unittest.cc

Issue 1538643004: Use an explicit identifier in Config (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Suppress Chrome's Clang plugins warnings for webrtc_common Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/test/common_unittest.cc

diff --git a/webrtc/test/common_unittest.cc b/webrtc/test/common_unittest.cc

index 082c18c2c7d9361fde111a1880e078bbf050edb7..a239dade73fdadebfcece97614805d6003869d5f 100644

--- a/webrtc/test/common_unittest.cc

+++ b/webrtc/test/common_unittest.cc

@@ -15,6 +15,7 @@ namespace webrtc {

namespace {

struct MyExperiment {

+ static const ConfigOptionID identifier = ConfigOptionID::kMyExperimentForTest;

static const int kDefaultFactor;

static const int kDefaultOffset;

@@ -56,6 +57,8 @@ TEST(Config, SetNullSetsTheOptionBackToDefault) {

}

struct Algo1_CostFunction {

+ static const ConfigOptionID identifier =

+ ConfigOptionID::kAlgo1CostFunctionForTest;

Algo1_CostFunction() {}

virtual int cost(int x) const {