Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: webrtc/config.h

Issue 1538643004: Use an explicit identifier in Config (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Suppress Chrome's Clang plugins warnings for webrtc_common Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 // TODO(pbos): Move Config from common.h to here. 11 // TODO(pbos): Move Config from common.h to here.
12 12
13 #ifndef WEBRTC_CONFIG_H_ 13 #ifndef WEBRTC_CONFIG_H_
14 #define WEBRTC_CONFIG_H_ 14 #define WEBRTC_CONFIG_H_
15 15
16 #include <string> 16 #include <string>
17 #include <vector> 17 #include <vector>
18 18
19 #include "webrtc/common.h"
19 #include "webrtc/common_types.h" 20 #include "webrtc/common_types.h"
20 #include "webrtc/typedefs.h" 21 #include "webrtc/typedefs.h"
21 22
22 namespace webrtc { 23 namespace webrtc {
23 24
24 // Settings for NACK, see RFC 4585 for details. 25 // Settings for NACK, see RFC 4585 for details.
25 struct NackConfig { 26 struct NackConfig {
26 NackConfig() : rtp_history_ms(0) {} 27 NackConfig() : rtp_history_ms(0) {}
27 // Send side: the time RTP packets are stored for retransmissions. 28 // Send side: the time RTP packets are stored for retransmissions.
28 // Receive side: the time the receiver is prepared to wait for 29 // Receive side: the time the receiver is prepared to wait for
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // Controls the capacity of the packet buffer in NetEq. The capacity is the 122 // Controls the capacity of the packet buffer in NetEq. The capacity is the
122 // maximum number of packets that the buffer can contain. If the limit is 123 // maximum number of packets that the buffer can contain. If the limit is
123 // exceeded, the buffer will be flushed. The capacity does not affect the actual 124 // exceeded, the buffer will be flushed. The capacity does not affect the actual
124 // audio delay in the general case, since this is governed by the target buffer 125 // audio delay in the general case, since this is governed by the target buffer
125 // level (calculated from the jitter profile). It is only in the rare case of 126 // level (calculated from the jitter profile). It is only in the rare case of
126 // severe network freezes that a higher capacity will lead to a (transient) 127 // severe network freezes that a higher capacity will lead to a (transient)
127 // increase in audio delay. 128 // increase in audio delay.
128 struct NetEqCapacityConfig { 129 struct NetEqCapacityConfig {
129 NetEqCapacityConfig() : enabled(false), capacity(0) {} 130 NetEqCapacityConfig() : enabled(false), capacity(0) {}
130 explicit NetEqCapacityConfig(int value) : enabled(true), capacity(value) {} 131 explicit NetEqCapacityConfig(int value) : enabled(true), capacity(value) {}
132 static const ConfigOptionID identifier = ConfigOptionID::kNetEqCapacityConfig;
131 bool enabled; 133 bool enabled;
132 int capacity; 134 int capacity;
133 }; 135 };
134 136
135 struct NetEqFastAccelerate { 137 struct NetEqFastAccelerate {
136 NetEqFastAccelerate() : enabled(false) {} 138 NetEqFastAccelerate() : enabled(false) {}
137 explicit NetEqFastAccelerate(bool value) : enabled(value) {} 139 explicit NetEqFastAccelerate(bool value) : enabled(value) {}
140 static const ConfigOptionID identifier = ConfigOptionID::kNetEqFastAccelerate;
138 bool enabled; 141 bool enabled;
139 }; 142 };
140 143
141 struct VoicePacing { 144 struct VoicePacing {
142 VoicePacing() : enabled(false) {} 145 VoicePacing() : enabled(false) {}
143 explicit VoicePacing(bool value) : enabled(value) {} 146 explicit VoicePacing(bool value) : enabled(value) {}
147 static const ConfigOptionID identifier = ConfigOptionID::kVoicePacing;
144 bool enabled; 148 bool enabled;
145 }; 149 };
146 150
147 } // namespace webrtc 151 } // namespace webrtc
148 152
149 #endif // WEBRTC_CONFIG_H_ 153 #endif // WEBRTC_CONFIG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698