Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1521993002: Revert of Add APK targets to build libjingle tests for Android. (Closed)

Created:
5 years ago by stefan-webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add APK targets to build libjingle tests for Android. (patchset #10 id:180001 of https://codereview.webrtc.org/1511633002/ ) Reason for revert: Breaks bots. Original issue's description: > Add APK targets to build libjingle_peerconnection_unittests for Android. > > BUG=webrtc:2365 > > The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/ > > Committed: https://crrev.com/a78c0211fd50369a75a962385db6163bd8ded239 > Cr-Commit-Position: refs/heads/master@{#11007} TBR=kjellander@webrtc.org,tommi@webrtc.org,perkj@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:2365 Committed: https://crrev.com/bc14164aad254e72ce4d1e381b912b7d3acf5391 Cr-Commit-Position: refs/heads/master@{#11009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -359 lines) Patch
D talk/app/webrtc/java/jni/jni_onload.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory_unittest.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D talk/app/webrtc/test/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D talk/app/webrtc/test/androidtestinitializer.h View 1 chunk +0 lines, -37 lines 0 comments Download
D talk/app/webrtc/test/androidtestinitializer.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M talk/libjingle.gyp View 4 chunks +34 lines, -51 lines 0 comments Download
M talk/libjingle_tests.gyp View 4 chunks +13 lines, -20 lines 0 comments Download
M webrtc/build/android/test_runner.py View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/build/apk_test.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/build/apk_tests.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/build/apk_tests_noop.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/system_wrappers/include/field_trial_default.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/system_wrappers/source/field_trial_default.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/field_trial.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/test/field_trial.cc View 4 chunks +23 lines, -13 lines 0 comments Download
M webrtc/test/test.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
stefan-webrtc
Created Revert of Add APK targets to build libjingle tests for Android.
5 years ago (2015-12-14 12:30:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521993002/1
5 years ago (2015-12-14 12:31:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 12:31:23 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-14 12:31:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc14164aad254e72ce4d1e381b912b7d3acf5391
Cr-Commit-Position: refs/heads/master@{#11009}

Powered by Google App Engine
This is Rietveld 408576698