Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: talk/libjingle_tests.gyp

Issue 1521993002: Revert of Add APK targets to build libjingle tests for Android. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/libjingle.gyp ('k') | webrtc/build/android/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/libjingle_tests.gyp
diff --git a/talk/libjingle_tests.gyp b/talk/libjingle_tests.gyp
index 20cbd035fc2e66d0ecda28c960f47a0d9483ddb5..511f7d5ffc6cc3bac5fa5abe3bb476db9ca7b684 100755
--- a/talk/libjingle_tests.gyp
+++ b/talk/libjingle_tests.gyp
@@ -176,7 +176,7 @@
}, # target libjingle_p2p_unittest
{
'target_name': 'libjingle_peerconnection_unittest',
- 'type': '<(gtest_target_type)',
+ 'type': 'executable',
'dependencies': [
'<(DEPTH)/testing/gmock.gyp:gmock',
'<(webrtc_root)/base/base_tests.gyp:rtc_base_tests_utils',
@@ -207,6 +207,7 @@
# 'app/webrtc/peerconnectionproxy_unittest.cc',
'app/webrtc/remotevideocapturer_unittest.cc',
'app/webrtc/rtpsenderreceiver_unittest.cc',
+ 'app/webrtc/sctputils.cc',
'app/webrtc/statscollector_unittest.cc',
'app/webrtc/test/fakeaudiocapturemodule.cc',
'app/webrtc/test/fakeaudiocapturemodule.h',
@@ -227,14 +228,17 @@
],
'conditions': [
['OS=="android"', {
- 'sources': [
- 'app/webrtc/test/androidtestinitializer.cc',
- 'app/webrtc/test/androidtestinitializer.h',
- ],
- 'dependencies': [
- '<(DEPTH)/testing/android/native_test.gyp:native_test_native_code',
- 'libjingle.gyp:libjingle_peerconnection_jni',
- ],
+ # We want gmock features that use tr1::tuple, but we currently
+ # don't support the variadic templates used by libstdc++'s
+ # implementation. gmock supports this scenario by providing its
+ # own implementation but we must opt in to it.
+ 'defines': [
+ 'GTEST_USE_OWN_TR1_TUPLE=1',
+ # GTEST_USE_OWN_TR1_TUPLE only works if GTEST_HAS_TR1_TUPLE is set.
+ # gmock r625 made it so that GTEST_HAS_TR1_TUPLE is set to 0
+ # automatically on android, so it has to be set explicitly here.
+ 'GTEST_HAS_TR1_TUPLE=1',
+ ],
}],
],
}, # target libjingle_peerconnection_unittest
@@ -389,17 +393,6 @@
}, # target apprtc_signaling_gunit_test
],
}],
- ['OS=="android"', {
- 'targets': [
- {
- 'target_name': 'libjingle_peerconnection_unittest_apk_target',
- 'type': 'none',
- 'dependencies': [
- '<(DEPTH)/webrtc/build/apk_tests.gyp:libjingle_peerconnection_unittest_apk',
- ],
- },
- ],
- }],
['test_isolation_mode != "noop"', {
'targets': [
{
« no previous file with comments | « talk/libjingle.gyp ('k') | webrtc/build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698