Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: webrtc/test/field_trial.cc

Issue 1521993002: Revert of Add APK targets to build libjingle tests for Android. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/test/field_trial.h ('k') | webrtc/test/test.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/test/field_trial.h" 11 #include "webrtc/test/field_trial.h"
12 12
13 #include <algorithm> 13 #include <algorithm>
14 #include <cassert> 14 #include <cassert>
15 #include <cstdio> 15 #include <cstdio>
16 #include <cstdlib> 16 #include <cstdlib>
17 #include <map> 17 #include <map>
18 #include <string> 18 #include <string>
19 19
20 #include "webrtc/system_wrappers/include/field_trial.h" 20 #include "webrtc/system_wrappers/include/field_trial.h"
21 #include "webrtc/system_wrappers/include/field_trial_default.h"
22 21
23 namespace webrtc { 22 namespace webrtc {
24 namespace { 23 namespace {
24 // Clients of this library have show a clear intent to setup field trials by
25 // linking with it. As so try to crash if they forget to call
26 // InitFieldTrialsFromString before webrtc tries to access a field trial.
25 bool field_trials_initiated_ = false; 27 bool field_trials_initiated_ = false;
28 std::map<std::string, std::string> field_trials_;
26 } // namespace 29 } // namespace
27 30
31 namespace field_trial {
32 std::string FindFullName(const std::string& trial_name) {
33 assert(field_trials_initiated_);
34 std::map<std::string, std::string>::const_iterator it =
35 field_trials_.find(trial_name);
36 if (it == field_trials_.end())
37 return std::string();
38 return it->second;
39 }
40 } // namespace field_trial
41
28 namespace test { 42 namespace test {
29 // Note: this code is copied from src/base/metrics/field_trial.cc since the aim 43 // Note: this code is copied from src/base/metrics/field_trial.cc since the aim
30 // is to mimic chromium --force-fieldtrials. 44 // is to mimic chromium --force-fieldtrials.
31 void InitFieldTrialsFromString(const std::string& trials_string) { 45 void InitFieldTrialsFromString(const std::string& trials_string) {
32 static const char kPersistentStringSeparator = '/'; 46 static const char kPersistentStringSeparator = '/';
33 47
34 // Catch an error if this is called more than once. 48 // Catch an error if this is called more than once.
35 assert(!field_trials_initiated_); 49 assert(!field_trials_initiated_);
36 field_trials_initiated_ = true; 50 field_trials_initiated_ = true;
37 51
38 if (trials_string.empty()) 52 if (trials_string.empty())
39 return; 53 return;
40 54
41 size_t next_item = 0; 55 size_t next_item = 0;
42 std::map<std::string, std::string> field_trials;
43 while (next_item < trials_string.length()) { 56 while (next_item < trials_string.length()) {
44 size_t name_end = trials_string.find(kPersistentStringSeparator, next_item); 57 size_t name_end = trials_string.find(kPersistentStringSeparator, next_item);
45 if (name_end == trials_string.npos || next_item == name_end) 58 if (name_end == trials_string.npos || next_item == name_end)
46 break; 59 break;
47 size_t group_name_end = trials_string.find(kPersistentStringSeparator, 60 size_t group_name_end = trials_string.find(kPersistentStringSeparator,
48 name_end + 1); 61 name_end + 1);
49 if (group_name_end == trials_string.npos || name_end + 1 == group_name_end) 62 if (group_name_end == trials_string.npos || name_end + 1 == group_name_end)
50 break; 63 break;
51 std::string name(trials_string, next_item, name_end - next_item); 64 std::string name(trials_string, next_item, name_end - next_item);
52 std::string group_name(trials_string, name_end + 1, 65 std::string group_name(trials_string, name_end + 1,
53 group_name_end - name_end - 1); 66 group_name_end - name_end - 1);
54 next_item = group_name_end + 1; 67 next_item = group_name_end + 1;
55 68
56 // Fail if duplicate with different group name. 69 // Fail if duplicate with different group name.
57 if (field_trials.find(name) != field_trials.end() && 70 if (field_trials_.find(name) != field_trials_.end() &&
58 field_trials.find(name)->second != group_name) { 71 field_trials_.find(name)->second != group_name)
59 break; 72 break;
60 }
61 73
62 field_trials[name] = group_name; 74 field_trials_[name] = group_name;
63 75
64 // Successfully parsed all field trials from the string. 76 // Successfully parsed all field trials from the string.
65 if (next_item == trials_string.length()) { 77 if (next_item == trials_string.length())
66 webrtc::field_trial::InitFieldTrialsFromString(trials_string.c_str());
67 return; 78 return;
68 }
69 } 79 }
70 // Using fprintf as LOG does not print when this is called early in main. 80 // Using fprintf as LOG does not print when this is called early in main.
71 fprintf(stderr, "Invalid field trials string.\n"); 81 fprintf(stderr, "Invalid field trials string.\n");
72 82
73 // Using abort so it crashes in both debug and release mode. 83 // Using abort so it crashes in both debug and release mode.
74 abort(); 84 abort();
75 } 85 }
76 86
77 ScopedFieldTrials::ScopedFieldTrials(const std::string& config) 87 ScopedFieldTrials::ScopedFieldTrials(const std::string& config)
78 : previous_field_trials_(webrtc::field_trial::GetFieldTrialString()) { 88 : previous_field_trials_(field_trials_) {
79 assert(field_trials_initiated_); 89 assert(field_trials_initiated_);
80 field_trials_initiated_ = false; 90 field_trials_initiated_ = false;
81 current_field_trials_ = config; 91 field_trials_.clear();
82 InitFieldTrialsFromString(current_field_trials_); 92 InitFieldTrialsFromString(config);
83 } 93 }
84 94
85 ScopedFieldTrials::~ScopedFieldTrials() { 95 ScopedFieldTrials::~ScopedFieldTrials() {
86 // Should still be initialized, since InitFieldTrials is called from ctor. 96 // Should still be initialized, since InitFieldTrials is called from ctor.
87 // That's why we don't restore the flag. 97 // That's why we don't restore the flag.
88 assert(field_trials_initiated_); 98 assert(field_trials_initiated_);
89 webrtc::field_trial::InitFieldTrialsFromString(previous_field_trials_); 99 field_trials_ = previous_field_trials_;
90 } 100 }
91 101
92 } // namespace test 102 } // namespace test
93 } // namespace webrtc 103 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/test/field_trial.h ('k') | webrtc/test/test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698