Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1507643004: Lint clean video/ and add lint presubmit check. (Closed)

Created:
5 years ago by mflodman
Modified:
5 years ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Lint clean video/ and add lint presubmit check. BUG=webrtc:5316 Committed: https://crrev.com/d1590b2571c4cb33416e14c92e4f2dfed42ec3d4 Cr-Commit-Position: refs/heads/master@{#10953}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : ostringstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video/rampup_tests.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mflodman
Peter, Time for the video folder.
5 years ago (2015-12-08 13:28:03 UTC) #1
mflodman
And actually adding Peter...
5 years ago (2015-12-08 13:28:26 UTC) #3
pbos-webrtc
lgtm with to_string removed https://codereview.webrtc.org/1507643004/diff/20001/webrtc/video/rampup_tests.cc File webrtc/video/rampup_tests.cc (right): https://codereview.webrtc.org/1507643004/diff/20001/webrtc/video/rampup_tests.cc#newcode325 webrtc/video/rampup_tests.cc:325: str += std::to_string(num_streams_); C++11 library ...
5 years ago (2015-12-09 11:21:49 UTC) #4
mflodman
https://codereview.webrtc.org/1507643004/diff/20001/webrtc/video/rampup_tests.cc File webrtc/video/rampup_tests.cc (right): https://codereview.webrtc.org/1507643004/diff/20001/webrtc/video/rampup_tests.cc#newcode325 webrtc/video/rampup_tests.cc:325: str += std::to_string(num_streams_); On 2015/12/09 11:21:49, pbos-webrtc wrote: > ...
5 years ago (2015-12-09 13:49:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507643004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507643004/40001
5 years ago (2015-12-09 13:49:46 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-09 15:08:05 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-09 15:08:12 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1590b2571c4cb33416e14c92e4f2dfed42ec3d4
Cr-Commit-Position: refs/heads/master@{#10953}

Powered by Google App Engine
This is Rietveld 408576698