Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: webrtc/video/video_quality_test.cc

Issue 1507643004: Lint clean video/ and add lint presubmit check. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: ostringstream Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_quality_test.h ('k') | webrtc/video/video_receive_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_quality_test.cc
diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc
index 09c1037ec749e50edd240688179c8c8d26dc9d9b..d26268980d45e7ad7d698f678f005e40a99d77f2 100644
--- a/webrtc/video/video_quality_test.cc
+++ b/webrtc/video/video_quality_test.cc
@@ -13,6 +13,7 @@
#include <deque>
#include <map>
#include <sstream>
+#include <string>
#include <vector>
#include "testing/gtest/include/gtest/gtest.h"
@@ -97,7 +98,6 @@ class VideoAnalyzer : public PacketReceiver,
thread->Start();
comparison_thread_pool_.push_back(thread);
}
-
}
~VideoAnalyzer() {
@@ -1017,14 +1017,16 @@ void VideoQualityTest::RunWithVideoRenderer(const Params& params) {
test::VideoRenderer::Create("Local Preview", params_.common.width,
params_.common.height));
size_t stream_id = params_.ss.selected_stream;
- char title[32];
- if (params_.ss.streams.size() == 1) {
- sprintf(title, "Loopback Video");
- } else {
- sprintf(title, "Loopback Video - Stream #%" PRIuS, stream_id);
+ std::string title = "Loopback Video";
+ if (params_.ss.streams.size() > 1) {
+ std::ostringstream s;
+ s << stream_id;
+ title += " - Stream #" + s.str();
}
+
rtc::scoped_ptr<test::VideoRenderer> loopback_video(
- test::VideoRenderer::Create(title, params_.ss.streams[stream_id].width,
+ test::VideoRenderer::Create(title.c_str(),
+ params_.ss.streams[stream_id].width,
params_.ss.streams[stream_id].height));
// TODO(ivica): Remove bitrate_config and use the default Call::Config(), to
« no previous file with comments | « webrtc/video/video_quality_test.h ('k') | webrtc/video/video_receive_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698