Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1507643004: Lint clean video/ and add lint presubmit check. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: ostringstream Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | webrtc/video/rampup_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 0a5e5dfba74c608b6f528284100da9cdd8b975ae..26818f04bcf8a269df36d475424918d025fb56eb 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -48,7 +48,7 @@
namespace webrtc {
-static const unsigned long kSilenceTimeoutMs = 2000;
+static const uint32_t kSilenceTimeoutMs = 2000;
class EndToEndTest : public test::CallTest {
public:
@@ -558,7 +558,7 @@ TEST_F(EndToEndTest, CanReceiveFec) {
TEST_F(EndToEndTest, DISABLED_ReceivedFecPacketsNotNacked) {
class FecNackObserver : public test::EndToEndTest {
public:
- explicit FecNackObserver()
+ FecNackObserver()
: EndToEndTest(kDefaultTimeoutMs),
state_(kFirstPacket),
fec_sequence_number_(0),
@@ -3047,7 +3047,7 @@ TEST_F(EndToEndTest, RespectsNetworkState) {
}
bool sender_done = false;
bool receiver_done = false;
- while(!sender_done || !receiver_done) {
+ while (!sender_done || !receiver_done) {
packet_event_->Wait(kSilenceTimeoutMs);
int64_t time_now_ms = clock_->TimeInMilliseconds();
rtc::CritScope lock(&test_crit_);
@@ -3135,7 +3135,7 @@ TEST_F(EndToEndTest, CallReportsRttForSender) {
TEST_F(EndToEndTest, NewSendStreamsRespectNetworkDown) {
class UnusedEncoder : public test::FakeEncoder {
- public:
+ public:
UnusedEncoder() : FakeEncoder(Clock::GetRealTimeClock()) {}
int32_t Encode(const VideoFrame& input_image,
const CodecSpecificInfo* codec_specific_info,
« no previous file with comments | « PRESUBMIT.py ('k') | webrtc/video/rampup_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698