Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 1481003002: Revert of Make overuse estimator one dimensional. (Closed)

Created:
3 years, 6 months ago by stefan-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make overuse estimator one dimensional. (patchset #5 id:80001 of https://codereview.webrtc.org/1376423002/ ) Reason for revert: Broke webrtc_perf_tests on bots. Original issue's description: > Make overuse estimator one dimensional. > > This drops the payload size difference dimension of the Kalman filter, > which doesn't improve the quality of the estimation when pacing packets > on the send-side. > > R=gaetano.carlucci@gmail.com, mflodman@webrtc.org, terelius@webrtc.org > > Committed: https://crrev.com/06e05a85b9e4def75ed5e6b582c4df842616f25f > Cr-Commit-Position: refs/heads/master@{#10809} TBR=terelius@webrtc.org,mflodman@webrtc.org,gaetano.carlucci@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/64c0a0a1110a69d722b6f7610e4096fe3288fe67 Cr-Commit-Position: refs/heads/master@{#10816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -300 lines) Patch
M webrtc/common_types.h View 1 chunk +25 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/inter_arrival.h View 2 chunks +12 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/inter_arrival.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc View 9 chunks +114 lines, -78 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc View 15 chunks +189 lines, -152 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_estimator.h View 2 chunks +9 lines, -10 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc View 4 chunks +66 lines, -35 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_format_remb_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
stefan-webrtc
Created Revert of Make overuse estimator one dimensional.
3 years, 6 months ago (2015-11-27 09:02:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481003002/1
3 years, 6 months ago (2015-11-27 09:02:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 6 months ago (2015-11-27 09:02:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64c0a0a1110a69d722b6f7610e4096fe3288fe67 Cr-Commit-Position: refs/heads/master@{#10816}
3 years, 6 months ago (2015-11-27 09:02:43 UTC) #5
mflodman
3 years, 6 months ago (2015-11-27 09:26:08 UTC) #6
Message was sent while issue was closed.
Nooooo!

But LGTM

Powered by Google App Engine
This is Rietveld 408576698