Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: webrtc/modules/remote_bitrate_estimator/inter_arrival.h

Issue 1481003002: Revert of Make overuse estimator one dimensional. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_types.h ('k') | webrtc/modules/remote_bitrate_estimator/inter_arrival.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/remote_bitrate_estimator/inter_arrival.h
diff --git a/webrtc/modules/remote_bitrate_estimator/inter_arrival.h b/webrtc/modules/remote_bitrate_estimator/inter_arrival.h
index 64ad1f68d3561de47e2ace6b0335e0b48809be8e..427bafcf96ffaedea1ce6ffca4ab8c56635b54f4 100644
--- a/webrtc/modules/remote_bitrate_estimator/inter_arrival.h
+++ b/webrtc/modules/remote_bitrate_estimator/inter_arrival.h
@@ -24,7 +24,7 @@
class InterArrival {
public:
// A timestamp group is defined as all packets with a timestamp which are at
- // most timestamp_group_length_ticks newer than the first timestamp in that
+ // most timestamp_group_length_ticks older than the first timestamp in that
// group.
InterArrival(uint32_t timestamp_group_length_ticks,
double timestamp_to_ms_coeff,
@@ -34,21 +34,30 @@
// group is still incomplete or if only one group has been completed.
// |timestamp| is the timestamp.
// |arrival_time_ms| is the local time at which the packet arrived.
+ // |packet_size| is the size of the packet.
// |timestamp_delta| (output) is the computed timestamp delta.
// |arrival_time_delta_ms| (output) is the computed arrival-time delta.
+ // |packet_size_delta| (output) is the computed size delta.
bool ComputeDeltas(uint32_t timestamp,
int64_t arrival_time_ms,
+ size_t packet_size,
uint32_t* timestamp_delta,
- int64_t* arrival_time_delta_ms);
+ int64_t* arrival_time_delta_ms,
+ int* packet_size_delta);
private:
struct TimestampGroup {
- TimestampGroup() : first_timestamp(0), timestamp(0), complete_time_ms(-1) {}
+ TimestampGroup()
+ : size(0),
+ first_timestamp(0),
+ timestamp(0),
+ complete_time_ms(-1) {}
bool IsFirstPacket() const {
return complete_time_ms == -1;
}
+ size_t size;
uint32_t first_timestamp;
uint32_t timestamp;
int64_t complete_time_ms;
« no previous file with comments | « webrtc/common_types.h ('k') | webrtc/modules/remote_bitrate_estimator/inter_arrival.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698