Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1426443007: Revert of Adding the ability to create an RtpSender without a track. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years, 1 month ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding the ability to create an RtpSender without a track. (patchset #8 id:140001 of https://codereview.webrtc.org/1413713003/ ) Reason for revert: Causing a compiler warning, and causing WebRtcBrowserTest.CallAndModifyStream to fail. Original issue's description: > Adding the ability to create an RtpSender without a track. > > This CL also changes AddStream to immediately create a sender, rather > than waiting until the track is seen in SDP. And the PeerConnection now > builds the list of "send streams" from the list of senders, rather than > the collection of local media streams. > > Committed: https://crrev.com/ac9d92ccbe2b29590c53f702e11dc625820480d5 > Cr-Commit-Position: refs/heads/master@{#10414} TBR=pthatcher@webrtc.org,pthatcher@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8f46c63f6f764254892f4111b54aa1cc8f32eeeb Cr-Commit-Position: refs/heads/master@{#10417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -719 lines) Patch
M talk/app/webrtc/audiotrack.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/mediastreaminterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/mediastreamprovider.h View 2 chunks +5 lines, -4 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 3 chunks +6 lines, -5 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 12 chunks +138 lines, -118 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 6 chunks +30 lines, -59 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +0 lines, -6 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionproxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/app/webrtc/rtpsender.h View 5 chunks +11 lines, -58 lines 0 comments Download
M talk/app/webrtc/rtpsender.cc View 5 chunks +58 lines, -170 lines 0 comments Download
M talk/app/webrtc/rtpsenderinterface.h View 3 chunks +0 lines, -20 lines 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 4 chunks +3 lines, -210 lines 0 comments Download
A talk/app/webrtc/test/fakemediastreamsignaling.h View 1 chunk +140 lines, -0 lines 0 comments Download
M talk/app/webrtc/videotrack.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/helpers.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/helpers.cc View 2 chunks +10 lines, -49 lines 0 comments Download
M webrtc/base/helpers_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Taylor Brandstetter
Created Revert of Adding the ability to create an RtpSender without a track.
5 years, 1 month ago (2015-10-26 21:10:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426443007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426443007/1
5 years, 1 month ago (2015-10-26 21:11:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 21:11:22 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f46c63f6f764254892f4111b54aa1cc8f32eeeb Cr-Commit-Position: refs/heads/master@{#10417}
5 years, 1 month ago (2015-10-26 21:11:36 UTC) #4
Taylor Brandstetter
5 years, 1 month ago (2015-11-09 22:36:24 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1413983004/ by deadbeef@webrtc.org.

The reason for reverting is: Relanding, after changing the expectations of
WebRtcBrowserTest.CallAndModifyStream..

Powered by Google App Engine
This is Rietveld 408576698