Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: talk/app/webrtc/mediastreamprovider.h

Issue 1426443007: Revert of Adding the ability to create an RtpSender without a track. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « talk/app/webrtc/mediastreaminterface.h ('k') | talk/app/webrtc/peerconnection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 namespace webrtc { 43 namespace webrtc {
44 44
45 // TODO(deadbeef): Change the key from an ssrc to a "sender_id" or 45 // TODO(deadbeef): Change the key from an ssrc to a "sender_id" or
46 // "receiver_id" string, which will be the MSID in the short term and MID in 46 // "receiver_id" string, which will be the MSID in the short term and MID in
47 // the long term. 47 // the long term.
48 48
49 // TODO(deadbeef): These interfaces are effectively just a way for the 49 // TODO(deadbeef): These interfaces are effectively just a way for the
50 // RtpSenders/Receivers to get to the BaseChannels. These interfaces should be 50 // RtpSenders/Receivers to get to the BaseChannels. These interfaces should be
51 // refactored away eventually, as the classes converge. 51 // refactored away eventually, as the classes converge.
52 52
53 // This interface is called by AudioRtpSender/Receivers to change the settings 53 // This interface is called by AudioTrackHandler classes in mediastreamhandler.h
54 // of an audio track connected to certain PeerConnection. 54 // to change the settings of an audio track connected to certain PeerConnection.
55 class AudioProviderInterface { 55 class AudioProviderInterface {
56 public: 56 public:
57 // Enable/disable the audio playout of a remote audio track with |ssrc|. 57 // Enable/disable the audio playout of a remote audio track with |ssrc|.
58 virtual void SetAudioPlayout(uint32_t ssrc, bool enable) = 0; 58 virtual void SetAudioPlayout(uint32_t ssrc, bool enable) = 0;
59 // Enable/disable sending audio on the local audio track with |ssrc|. 59 // Enable/disable sending audio on the local audio track with |ssrc|.
60 // When |enable| is true |options| should be applied to the audio track. 60 // When |enable| is true |options| should be applied to the audio track.
61 virtual void SetAudioSend(uint32_t ssrc, 61 virtual void SetAudioSend(uint32_t ssrc,
62 bool enable, 62 bool enable,
63 const cricket::AudioOptions& options, 63 const cricket::AudioOptions& options,
64 cricket::AudioRenderer* renderer) = 0; 64 cricket::AudioRenderer* renderer) = 0;
65 65
66 // Sets the audio playout volume of a remote audio track with |ssrc|. 66 // Sets the audio playout volume of a remote audio track with |ssrc|.
67 // |volume| is in the range of [0, 10]. 67 // |volume| is in the range of [0, 10].
68 virtual void SetAudioPlayoutVolume(uint32_t ssrc, double volume) = 0; 68 virtual void SetAudioPlayoutVolume(uint32_t ssrc, double volume) = 0;
69 69
70 protected: 70 protected:
71 virtual ~AudioProviderInterface() {} 71 virtual ~AudioProviderInterface() {}
72 }; 72 };
73 73
74 // This interface is called by VideoRtpSender/Receivers to change the settings 74 // This interface is called by VideoTrackHandler classes in mediastreamhandler.h
75 // of a video track connected to a certain PeerConnection. 75 // to change the settings of a video track connected to a certain
76 // PeerConnection.
76 class VideoProviderInterface { 77 class VideoProviderInterface {
77 public: 78 public:
78 virtual bool SetCaptureDevice(uint32_t ssrc, 79 virtual bool SetCaptureDevice(uint32_t ssrc,
79 cricket::VideoCapturer* camera) = 0; 80 cricket::VideoCapturer* camera) = 0;
80 // Enable/disable the video playout of a remote video track with |ssrc|. 81 // Enable/disable the video playout of a remote video track with |ssrc|.
81 virtual void SetVideoPlayout(uint32_t ssrc, 82 virtual void SetVideoPlayout(uint32_t ssrc,
82 bool enable, 83 bool enable,
83 cricket::VideoRenderer* renderer) = 0; 84 cricket::VideoRenderer* renderer) = 0;
84 // Enable sending video on the local video track with |ssrc|. 85 // Enable sending video on the local video track with |ssrc|.
85 virtual void SetVideoSend(uint32_t ssrc, 86 virtual void SetVideoSend(uint32_t ssrc,
86 bool enable, 87 bool enable,
87 const cricket::VideoOptions* options) = 0; 88 const cricket::VideoOptions* options) = 0;
88 89
89 protected: 90 protected:
90 virtual ~VideoProviderInterface() {} 91 virtual ~VideoProviderInterface() {}
91 }; 92 };
92 93
93 } // namespace webrtc 94 } // namespace webrtc
94 95
95 #endif // TALK_APP_WEBRTC_MEDIASTREAMPROVIDER_H_ 96 #endif // TALK_APP_WEBRTC_MEDIASTREAMPROVIDER_H_
OLDNEW
« no previous file with comments | « talk/app/webrtc/mediastreaminterface.h ('k') | talk/app/webrtc/peerconnection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698