Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1423693008: Revert of Add aecdump support to audioproc_f. (Closed)

Created:
3 years, 7 months ago by kjellander_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add aecdump support to audioproc_f. (patchset #8 id:200001 of https://codereview.webrtc.org/1409943002/ ) Reason for revert: This breaks iOS GYP generation as described on http://www.webrtc.org/native-code/ios I'm going to drive getting the build_with_libjingle=1 setting removed from the bots to match the official instructions. See https://code.google.com/p/webrtc/issues/detail?id=4653 for more context, as this is exactly what that issue tries to solve. Original issue's description: > Add aecdump support to audioproc_f. > > Add a new interface to abstract away file operations. This CL temporarily > removes support for dumping the output of reverse streams. It will be easy to > restore in the new framework, although we may decide to only allow it with > the aecdump format. > > We also now require the user to specify the output format, rather than > defaulting to the input format. > > TEST=Bit-exact output to the previous audioproc_f version using an input wav > file, and to the legacy audioproc using an aecdump file. > > Committed: https://crrev.com/bdafe31b86e9819b0adb9041f87e6194b7422b08 > Cr-Commit-Position: refs/heads/master@{#10460} TBR=aluebs@webrtc.org,peah@webrtc.org,andrew@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d279941bb54bfdc6e7324bf36cac76581474b96d Cr-Commit-Position: refs/heads/master@{#10523}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -464 lines) Patch
M webrtc/common_audio/wav_file.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/modules/audio_processing/test/audio_file_processor.h View 1 chunk +0 lines, -139 lines 0 comments Download
D webrtc/modules/audio_processing/test/audio_file_processor.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 1 4 chunks +146 lines, -55 lines 0 comments Download
M webrtc/modules/audio_processing/test/process_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.h View 1 2 chunks +0 lines, -32 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 1 2 chunks +9 lines, -42 lines 0 comments Download
M webrtc/system_wrappers/include/tick_util.h View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kjellander_webrtc
Created Revert of Add aecdump support to audioproc_f.
3 years, 7 months ago (2015-11-05 14:07:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423693008/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423693008/250001
3 years, 7 months ago (2015-11-05 14:08:53 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:250001)
3 years, 7 months ago (2015-11-05 14:09:07 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d279941bb54bfdc6e7324bf36cac76581474b96d Cr-Commit-Position: refs/heads/master@{#10523}
3 years, 7 months ago (2015-11-05 14:09:15 UTC) #8
kjellander_webrtc
3 years, 7 months ago (2015-11-05 14:22:35 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:250001) has been created in
https://codereview.webrtc.org/1419953010/ by kjellander@webrtc.org.

The reason for reverting is: Oh dear, this broke compilation. 
I guess more was built on top of this CL before I reverted it.

Reverting now for futher investigation (and re-land using CQ).

Powered by Google App Engine
This is Rietveld 408576698