Set send times in send time history via OnSentPacket.

Set send times in send time history via OnSentPacket.

BUG=webrtc:4173
Committed: https://crrev.com/bbe876f0d30ec806c7c4a12629eb1f19ab45fb86
Cr-Commit-Position: refs/heads/master@{#10384}

[stefan-webrtc, 2015-10-20 19:57:49]

Description was changed from

==========
Set send times in send time history via OnSentPacket.

BUG=
==========

to

==========
Set send times in send time history via OnSentPacket.

BUG=webrtc:4173
==========

[stefan-webrtc, 2015-10-20 19:57:55]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 19:58:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419503004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419503004/1

[stefan-webrtc, 2015-10-20 19:58:09]

stefan@webrtc.org changed reviewers:
+ sprang@webrtc.org

[commit-bot: I haz the power, 2015-10-20 21:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 21:58:20]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sprang_webrtc, 2015-10-22 14:51:03]

lgtm with nits

https://codereview.webrtc.org/1419503004/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
(right):

https://codereview.webrtc.org/1419503004/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc:67:
history_.OnSentPacket(kSeqNo, 1);
You (almost) always use AddAndRemoveOld and OnSentPacket in tandem, perhaps a
utility method would be in order?

https://codereview.webrtc.org/1419503004/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc:154:
PacketInfo info(0, 0, static_cast<uint16_t>(i), 0, false);
rename or reuse "info" from line 151

[stefan-webrtc, 2015-10-23 08:11:25]

https://codereview.webrtc.org/1419503004/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
(right):

https://codereview.webrtc.org/1419503004/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc:67:
history_.OnSentPacket(kSeqNo, 1);
On 2015/10/22 14:51:03, språng wrote:
> You (almost) always use AddAndRemoveOld and OnSentPacket in tandem, perhaps a
> utility method would be in order?

Done.

https://codereview.webrtc.org/1419503004/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc:154:
PacketInfo info(0, 0, static_cast<uint16_t>(i), 0, false);
On 2015/10/22 14:51:03, språng wrote:
> rename or reuse "info" from line 151

Done.

[stefan-webrtc, 2015-10-23 08:11:29]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2015-10-23 08:11:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419503004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419503004/1

[stefan-webrtc, 2015-10-23 08:11:44]

The CQ bit was unchecked by stefan@webrtc.org

[stefan-webrtc, 2015-10-23 08:12:40]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2015-10-23 08:12:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1419503004/#ps20001 (title:
"Comments addressed")

[commit-bot: I haz the power, 2015-10-23 08:12:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419503004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419503004/20001

[commit-bot: I haz the power, 2015-10-23 09:05:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-23 09:05:52]

Patchset 2 (id:??) landed as
https://crrev.com/bbe876f0d30ec806c7c4a12629eb1f19ab45fb86
Cr-Commit-Position: refs/heads/master@{#10384}