webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc - Issue 1419503004: Set send times in send time history via OnSentPacket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc

Issue 1419503004: Set send times in send time history via OnSentPacket. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/include/send_time_history.h ('k') | webrtc/modules/remote_bitrate_estimator/send_time_history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc

index 73b7b15fa4af45179ab9ac2c9a06d3932c679582..de4aec0a7791f854afd838b4100f43b8fee9552d 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc

@@ -45,7 +45,11 @@ void RemoteEstimatorProxy::IncomingPacket(int64_t arrival_time_ms,

size_t payload_size,

const RTPHeader& header,

bool was_paced) {

- RTC_DCHECK(header.extension.hasTransportSequenceNumber);

+ if (!header.extension.hasTransportSequenceNumber) {

+ LOG(LS_WARNING) << "RemoteEstimatorProxy: Incoming packet "

+ "is missing the transport sequence number extension!";

+ return;

+ }

rtc::CritScope cs(&lock_);

media_ssrc_ = header.ssrc;

OnPacketArrival(header.extension.transportSequenceNumber, arrival_time_ms);