Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1416773003: Revert of Add experiment on weak ping delay during call set up time (Closed)

Created:
5 years, 2 months ago by hbos
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ ) Reason for revert: This CL breaks Chromium, undefined reference link error to webrtc::field_trial::FindFullName. Adding the dependency system_wrappers to the rtc_p2p target is not enough to fix this. Looking at field_trial.h (in system_wrappers/interface/, not to be confused with the one in test/) the documentation says "WebRTC clients MUST provide an implementation of: ...FindFullName... Or link with a default one provided in: ...system_wrappers.gyp:field_trial_default). So maybe just depend on field_trial_default? Not sure what should be done in case there are implications to adding this dependency, I'm reverting this. Sorry :) Original issue's description: > Add experiment on weak ping delay during call set up time > > BUG= > R=pthatcher@webrtc.org > > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279 > Cr-Commit-Position: refs/heads/master@{#10343} TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -34 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 4 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hbos
Created Revert of Add experiment on weak ping delay during call set up time
5 years, 2 months ago (2015-10-21 08:36:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416773003/1
5 years, 2 months ago (2015-10-21 08:36:28 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 2 months ago (2015-10-21 08:36:38 UTC) #4
hbos
On 2015/10/21 08:36:38, commit-bot: I haz the power wrote: > Failed to apply the patch. ...
5 years, 2 months ago (2015-10-21 08:41:29 UTC) #5
guoweis_webrtc
5 years, 1 month ago (2015-10-26 22:09:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1413603005/ by guoweis@webrtc.org.

The reason for reverting is: https://codereview.chromium.org/1419253002 is
landed to address this linker issue. Keep my fingers crossed..

Powered by Google App Engine
This is Rietveld 408576698