Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1423443002: Revert of Add experiment on weak ping delay during call set up time (Closed)

Created:
5 years, 2 months ago by tommi
Modified:
5 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hbos
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ ) Reason for revert: guoweis - Here's the target that's failing: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=17 This has unfortunately been causing problems repeatedly for us since libjingle_nacl is maintained separately from libjingle (I don't know the history). The way this works for Chrome in general is that the FindFullName method is implemented in init_webrtc.cc in the overrides folder in Chrome and that hooks WebRTC up with Chrome's implementation. I'm not sure if that's the right thing to do for nacl, how webrtc is initialized there etc. I'll ping the nacl team for some help too offline and include you. Reverting this change for now. Original issue's description: > Add experiment on weak ping delay during call set up time > > BUG= > R=pthatcher@webrtc.org > > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279 > Cr-Commit-Position: refs/heads/master@{#10343} TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a01d44022355796d4fd86d00aae6d3263573b6f1 Cr-Commit-Position: refs/heads/master@{#10350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -34 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 4 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi
Created Revert of Add experiment on weak ping delay during call set up time
5 years, 2 months ago (2015-10-21 08:07:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423443002/1
5 years, 2 months ago (2015-10-21 08:07:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 08:07:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a01d44022355796d4fd86d00aae6d3263573b6f1 Cr-Commit-Position: refs/heads/master@{#10350}
5 years, 2 months ago (2015-10-21 08:07:41 UTC) #4
guoweis_webrtc
5 years, 2 months ago (2015-10-23 00:49:17 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1406153005/ by guoweis@webrtc.org.

The reason for reverting is: This should be safe to land now..

Powered by Google App Engine
This is Rietveld 408576698