Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1414793006: Remove deprecated IsUnresolved() method from SocketAddress API. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
AlexG, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, juberti1, pthatcher1, tommi, guoweis_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove deprecated IsUnresolved() method from SocketAddress API. This patch removes IsUnresolved() method and update the clients to use IsUnresolvedIP() instead. BUG=None R=perkj@webrtc.org TBR=glaznev@webrtc.org Committed: https://crrev.com/20a34619080005c3b0e49d85b307113ea2b180c3 Cr-Commit-Position: refs/heads/master@{#10487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M webrtc/base/macasyncsocket.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/physicalsocketserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/proxydetect.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/socketadapters.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/socketaddress.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/peer_connection_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/stunport.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/p2p/base/turnport.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
tfarina
5 years, 1 month ago (2015-11-01 01:29:53 UTC) #1
perkj_webrtc
Thanks for cleaning. Has Chrome been changed? It has to be done first. If so, ...
5 years, 1 month ago (2015-11-02 11:27:03 UTC) #2
tfarina
I think it was. I don't see other entries in https://code.google.com/p/chromium/codesearch#search/&q=%22IsUnresolved()%22&sq=package:chromium&type=cs
5 years, 1 month ago (2015-11-02 11:56:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414793006/1
5 years, 1 month ago (2015-11-02 23:25:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1530)
5 years, 1 month ago (2015-11-02 23:31:06 UTC) #7
tfarina
TBRing glaznev for webrtc/examples.
5 years, 1 month ago (2015-11-02 23:33:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414793006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414793006/1
5 years, 1 month ago (2015-11-02 23:33:51 UTC) #12
AlexG
lgtm for webrtc/examples +Guowei fyi
5 years, 1 month ago (2015-11-02 23:37:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 00:20:27 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 00:20:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20a34619080005c3b0e49d85b307113ea2b180c3
Cr-Commit-Position: refs/heads/master@{#10487}

Powered by Google App Engine
This is Rietveld 408576698