webrtc/base/socketadapters.cc - Issue 1414793006: Remove deprecated IsUnresolved() method from SocketAddress API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/socketadapters.cc

Issue 1414793006: Remove deprecated IsUnresolved() method from SocketAddress API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/socketadapters.cc

diff --git a/webrtc/base/socketadapters.cc b/webrtc/base/socketadapters.cc

index af2efb82c794f2596f23359f6cf8efa851f8abdb..2b513dca63dea5f463d677c07e6c5cfb5583e5d4 100644

--- a/webrtc/base/socketadapters.cc

+++ b/webrtc/base/socketadapters.cc

@@ -688,7 +688,7 @@ void AsyncSocksProxySocket::SendConnect() {

request.WriteUInt8(5); // Socks Version

request.WriteUInt8(1); // CONNECT

request.WriteUInt8(0); // Reserved

- if (dest_.IsUnresolved()) {

+ if (dest_.IsUnresolvedIP()) {

std::string hostname = dest_.hostname();

request.WriteUInt8(3); // DOMAINNAME

request.WriteUInt8(static_cast<uint8_t>(hostname.size()));

« no previous file with comments | « webrtc/base/proxydetect.cc ('k') | webrtc/base/socketaddress.h » ('j') | no next file with comments »