webrtc/base/proxydetect.cc - Issue 1414793006: Remove deprecated IsUnresolved() method from SocketAddress API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/proxydetect.cc

Issue 1414793006: Remove deprecated IsUnresolved() method from SocketAddress API. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/proxydetect.cc

diff --git a/webrtc/base/proxydetect.cc b/webrtc/base/proxydetect.cc

index b144d20a9748dc9745fa0142891bf7f10f01405b..c0cfab9b0eb6b918c0cd5661db0793403bdd903c 100644

--- a/webrtc/base/proxydetect.cc

+++ b/webrtc/base/proxydetect.cc

@@ -222,7 +222,7 @@ bool ProxyItemMatch(const Url<char>& url, char * item, size_t len) {

uint32_t mask = (m == 0) ? 0 : (~0UL) << (32 - m);

SocketAddress addr(url.host(), 0);

// TODO: Support IPv6 proxyitems. This code block is IPv4 only anyway.

- return !addr.IsUnresolved() &&

+ return !addr.IsUnresolvedIP() &&

((addr.ipaddr().v4AddressAsHostOrderInteger() & mask) == (ip & mask));

}

« no previous file with comments | « webrtc/base/physicalsocketserver.cc ('k') | webrtc/base/socketadapters.cc » ('j') | no next file with comments »